This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix(snap): Refactor to avoid conflicts with readonly config provider directory #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory Signed-off-by: Mengyi Wang <[email protected]>
farshidtz
suggested changes
Mar 18, 2023
snap/local/helper-go/main.go
Outdated
| @@ -19,6 +19,8 @@ import ( | |||
| "os" | |||
| ) | |||
|
|
|||
| const app = "kuiperd" | |||
There was a problem hiding this comment.
Having a global variable called app is confusing because this snap has two apps.
There was a problem hiding this comment.
It has been updated to const daemonApp = "kuiperd".
There was a problem hiding this comment.
My comment was about the confusion in name when set as a global variable in main.go, not the local variable in configure(), but it is a good improvement in general.
There was a problem hiding this comment.
so would you like me to keep it as a local variable?
|
farshidtz
suggested changes
Mar 20, 2023
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
MonicaisHer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to incorporate the following fixes:
For testing instructions, please refer to edgexfoundry/device-mqtt-go#535