Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update sample configuration of mqtt-export to use MQTTSecretSend #108 #109

Closed
wants to merge 1 commit into from

Conversation

judehung
Copy link
Member

@judehung judehung commented Sep 4, 2020

MQTTSend has been deprecated and the documentation suggests to use MQTTSecretSend.
However, the sample configuration under res/mqtt-export still uses MQTTSend.
This commit updates the sample configuration to use MQTTSecretSend.

Signed-off-by: Jude Hung [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Adjust the sample configuration

What is the current behavior?

Issue Number:
#108

What is the new behavior?

Sample configuration under res/mqtt-export specifies MQTTSecretSend in the ExecutionOrder

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

No

Are there any specific instructions or things that should be known prior to reviewing?

https://docs.edgexfoundry.org/1.2/microservices/application/AppServiceConfigurable/#mqttsend

Other information

MQTTSend has been deprecated and the documentation suggests to use MQTTSecretSend.
However, the sample configuration under res/mqtt-export still uses MQTTSend.
This commit updates the sample configuration to use MQTTSecretSend.

Signed-off-by: Jude Hung <[email protected]>
@judehung judehung changed the title Update sample configuration of mqtt-export to use MQTTSecretSend fix: Update sample configuration of mqtt-export to use MQTTSecretSend #108 Sep 4, 2020
@judehung judehung closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant