Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample configuration under res/mqtt-export still uses deprecated MQTTSend #108

Closed
judehung opened this issue Sep 4, 2020 · 3 comments
Closed

Sample configuration under res/mqtt-export still uses deprecated MQTTSend #108

judehung opened this issue Sep 4, 2020 · 3 comments
Assignees
@lenny-goodell
Labels
3-high priority denoting release-blocking issues breaking change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Milestone
Ireland

Comments

@judehung
Copy link
Member

judehung commented Sep 4, 2020

Per https://docs.edgexfoundry.org/1.2/microservices/application/AppServiceConfigurable/#mqttsend, MQTTSend has been deprecated and the community suggests to use MQTTSecretSend. However, the sample configuration under res/mqtt-export still uses MQTTSend. The community shall consider to update the sample configuration to use MQTTSecretSend.
This was referenced Sep 4, 2020
Closed
Closed
@lenny-goodell
Copy link
Member

@judehung , We specific didn't change the profile to use the new MqttSecretSend since IMHO, it would be a breaking change. We did add the MqttSecretSend to the profile configuration so user could configure and use it. @rsdmike , @jpwhitemn , Thoughts on this?

@cloudxxx8 cloudxxx8 mentioned this issue Sep 13, 2020
Merged
12 tasks
@cloudxxx8
Copy link
Member

The race condition issue is only fixed in MQTTSecretSend, so we need this change for the automatic performance test
edgexfoundry/app-functions-sdk-go#474

@cloudxxx8
Copy link
Member

Sorry, I just noticed it has been fixed in MQTTSend, too.

@rsdmike rsdmike added hold Intended for PRs we want to flag for ongoing review ireland labels Sep 18, 2020
@rsdmike rsdmike removed the hold Intended for PRs we want to flag for ongoing review label Nov 20, 2020
@rsdmike rsdmike added this to the Ireland milestone Nov 20, 2020
@rsdmike rsdmike added 1-low priority denoting isolated changes 2-medium priority denoting issues with cross-cutting project impact 3-high priority denoting release-blocking issues tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds and removed ireland 1-low priority denoting isolated changes 2-medium priority denoting issues with cross-cutting project impact labels Nov 20, 2020
@lenny-goodell lenny-goodell mentioned this issue Dec 4, 2020
Merged
12 tasks
@lenny-goodell lenny-goodell self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
3-high priority denoting release-blocking issues breaking change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Milestone
Ireland
Development

No branches or pull requests
4 participants
@cloudxxx8 @rsdmike @judehung @lenny-goodell