feat: Implement transform to add Tags to Event #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is draft until PR for go-mod-core-contracts is merged builds will fail due to the |
lenny-goodell
force-pushed
the
AddTags
branch
2 times, most recently
from
61b93bc to
acb6ca3
Compare
closes #455 & #369 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
AddTags
branch
from
acb6ca3 to
6ebd0a8
Compare
brian-intel
approved these changes
Sep 8, 2020
This was
linked to
issues
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
None.
Issue Number: #455 & #369
What is the new behavior?
AddTags function now available to custom app services and to App Service Configurable.
Also had to fix issue with XML marshaling due to error thrown due to
mapnot supported by XML marshal provided in Go.Also added missing copyright headers to other transform files.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information