Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transform to add tags to events from configuration #455

Closed
lenny-goodell opened this issue Aug 21, 2020 · 1 comment · Fixed by #467
Closed

Add transform to add tags to events from configuration #455

lenny-goodell opened this issue Aug 21, 2020 · 1 comment · Fixed by #467
Assignees
@lenny-goodell
Labels
2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services enhancement New feature or request hanoi Hanoi release
Milestone
Hanoi

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Aug 21, 2020 •
edited
Loading

AddTags transform takes tags from transform's configuration when initialized.

  • For ASC support a new pipeline configuration needs to be added for the transform to specify the tags in comma separated list of key:values, e.g. tag-key:tag-value, ...
  • AddTags requires incoming data to be an Edgex Event model.
  • Simply adds the tags from transform's configuration to the Event.Tags map one by one so any tags already present remain unless they are duplicate in which case they get overriding
@lenny-goodell
Copy link
Member Author

Dependent on edgexfoundry/go-mod-core-contracts#270

@rsdmike rsdmike added the enhancement New feature or request label Aug 28, 2020
@lenny-goodell lenny-goodell self-assigned this Sep 3, 2020
@lenny-goodell lenny-goodell added this to the Hanoi milestone Sep 3, 2020
@lenny-goodell lenny-goodell added 2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services hanoi Hanoi release labels Sep 3, 2020
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Sep 4, 2020
feat: Implement transform to add Tags to Event
75984c1 
closes #455 & #369

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell mentioned this issue Sep 4, 2020
Merged
12 tasks
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Sep 4, 2020
feat: Implement transform to add Tags to Event
61b93bc 
closes #455 & #369

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Sep 4, 2020
feat: Implement transform to add Tags to Event
acb6ca3 
closes #455 & #369

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Sep 4, 2020
feat: Implement transform to add Tags to Event
6ebd0a8 
closes #455 & #369

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell linked a pull request Sep 8, 2020 that will close this issue
feat: Implement transform to add Tags to Event #467
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services enhancement New feature or request hanoi Hanoi release
Projects
None yet
Milestone
Hanoi
Development

Successfully merging a pull request may close this issue.

feat: Implement transform to add Tags to Event lenny-goodell/app-functions-sdk-go
2 participants
@rsdmike @lenny-goodell