fix: Provided custom XML marshaling of Event #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
cloudxxx8,
jpwhitemn,
rsdmike,
weichou1229 and
lindseysimple
cloudxxx8
previously requested changes
Sep 4, 2020
Disable XML marshaling of Event Tags field so error isn't thrown Add custom ToXML() function that handles the Tags field close #276 Signed-off-by: lenny <[email protected]>
12 tasks
jpwhitemn
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Go's XML marshal doesn't support maps and throws error when marshaling event due to Tags field.
Issue Number: #276
What is the new behavior?
Disabled XML marshaling of Event Tags field via attribute so error isn't thrown
Add custom ToXML() function that handles the Tags field after marshaling rest of Event fields.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
no
Other information