genpolicy: allow contrast env vars for coordinator #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
burgerdev
approved these changes
Jun 17, 2024
packages/by-name/microsoft/genpolicy/genpolicy_msft_settings_coordinator.patch
Outdated
Show resolved
Hide resolved
davidweisse
force-pushed
the
dav/coordinator-policy-env-vars
branch
from
654762d to
8dc4aae
Compare
katexochen
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Coordinator policy now allows environment variables of the form
CONTRAST_*, to allow enabling and configuring debug logging. For the dev setup, these changes are also applied to the default policy settings. This allows configuring logging for the Coordinator as well as the Initializer or Service Mesh, but also allows changing the Proxy config for Envoy, so for the release the patches are only applied to the Coordinator policy.