use source.ts includes to ensure highlighting works on github #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#2
https://discord.com/channels/423256550564691970/1200066074297782323
β Type of change
π Description
I've had confirmation that github uses the atom javascript grammar rather than the microsoft javascript grammar when being included in a textmate grammar. This means
source.js#expression
will not work on github.You can see how github will highlight edge files using this preview app which also used the atom javascript grammar.
Nova Lightshow JS preview
This is how it highlights using source.ts instead
Nova Lightshow TS preview
π Checklist
I have updated the documentation accordingly.(no need)