Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use source.ts includes to ensure highlighting works on github #3

Merged

Conversation

evoactivity
Copy link
Contributor

πŸ”— Linked issue

#2

https://discord.com/channels/423256550564691970/1200066074297782323

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I've had confirmation that github uses the atom javascript grammar rather than the microsoft javascript grammar when being included in a textmate grammar. This means source.js#expression will not work on github.

You can see how github will highlight edge files using this preview app which also used the atom javascript grammar.
Nova Lightshow JS preview
image

This is how it highlights using source.ts instead
Nova Lightshow TS preview
image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. (no need)

@thetutlage thetutlage merged commit 90ee5da into edge-js:main Feb 5, 2024
6 checks passed
@thetutlage
Copy link
Member

Thanks πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants