Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must use typescript grammar to ensure GitHub compatibility #2

Closed
evoactivity opened this issue Feb 5, 2024 · 3 comments
Closed

Must use typescript grammar to ensure GitHub compatibility #2

evoactivity opened this issue Feb 5, 2024 · 3 comments

Comments

@evoactivity
Copy link
Contributor

evoactivity commented Feb 5, 2024

Package version

1.5.0

Describe the bug

I am working on getting GitHub support for highlighting edge files. GitHub uses the atom javascript textmate grammar which does not include #expression in it's repository causing the highlighting to be broken for highlighting powered by atom's javascript grammar.

You can see how github will highlight edge files using this preview app which also used the atom javascript grammar.
Nova Lightshow JS preview
image

This is how it highlights using source.ts instead
Nova Lightshow TS preview
image

Reproduction repo

No response

@thetutlage
Copy link
Member

Okay, if I get it right. We have to switch from source.js to source.ts and everything will work fine?

Does this change has to be made within this repo? Or can we just use source.ts inside the source code shared with Github linguist?

@evoactivity
Copy link
Contributor Author

It must be made in this repo. Linguist uses this repository as a submodule to pull in the grammar so it will be automatically updated as changes are made to the grammar without us needing to submit patches back to linguist.

@thetutlage
Copy link
Member

Cool. Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants