add back some tests and investigate haskell#2375 later

eddiemundo · Nov 29, 2021 · 21c55c9 · 21c55c9
1 parent 4475e77
commit 21c55c9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/plugins/hls-pragmas-plugin/src/Ide/Plugin/Pragmas.hs b/plugins/hls-pragmas-plugin/src/Ide/Plugin/Pragmas.hs
@@ -214,7 +214,7 @@ completion _ide _ complParams = do
     let (J.TextDocumentIdentifier uri) = complParams ^. J.textDocument
         position = complParams ^. J.position
     contents <- LSP.getVirtualFile $ toNormalizedUri uri
-    fmap (Right . J.InL) $ case (undefined, uriToFilePath' undefined) of
+    fmap (Right . J.InL) $ case (contents, uriToFilePath' uri) of
         (Just cnts, Just _path) ->
             result <$> VFS.getCompletionPrefix position cnts
             where

diff --git a/plugins/hls-pragmas-plugin/test/Main.hs b/plugins/hls-pragmas-plugin/test/Main.hs
@@ -20,8 +20,8 @@ tests :: TestTree
 tests =
   testGroup "pragmas"
   [ codeActionTests
-  -- , codeActionTests'
-  -- , completionTests
+  , codeActionTests'
+  , completionTests
   ]
 
 codeActionTests :: TestTree
@@ -125,7 +125,6 @@ completionTest testComment fileName te' label textFormat insertText detail [a, b
       item ^. L.insertTextFormat @?= textFormat
       item ^. L.insertText @?= insertText
       item ^. L.detail @?= detail
-completionTest _ _ _ _ _ _ _ _ = undefined
 
 goldenWithPragmas :: TestName -> FilePath -> (TextDocumentIdentifier -> Session ()) -> TestTree
 goldenWithPragmas title path = goldenWithHaskellDoc pragmasPlugin title testDataDir path "expected" "hs"