Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hls-pragmas-plugin: Tests time out #2375

Closed
maralorn opened this issue Nov 20, 2021 · 4 comments
Closed

hls-pragmas-plugin: Tests time out #2375

maralorn opened this issue Nov 20, 2021 · 4 comments
Labels
component: hls-pragmas-plugin os: nixos type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@maralorn
Copy link
Contributor

Building hls-pragmas-plugin 1.0.1.11 for hls 1.5.0.0 has a lot of timeouts in the tests when trying to build in nixpkgs. This can very well be an environment problem (e.g., a missing tool or something), but I am not sure what it could be.

See the log at: https://hydra.nixos.org/build/158849688/nixlog/6
@jneira jneira added component: hls-pragmas-plugin os: nixos type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: testing labels Nov 20, 2021
@eddiemundo
Copy link
Collaborator

I looked at this a little and if all of the completion and test logic is commented out except for the waitForDiagnostics line which is an lsp-test function, then the completion test(s) will timeout waiting for diagnostics.

I'm using nixos and used the flake.

eddiemundo added a commit to eddiemundo/haskell-language-server that referenced this issue Nov 29, 2021
@eddiemundo
add back some tests and investigate haskell#2375 later
21c55c9
mergify bot pushed a commit that referenced this issue Nov 30, 2021
@eddiemundo @jneira
Fix extension pragma inserted below ghc options pragma #2364 (#2392)
083f542 
* new parser for stuff before first declaration

* remove unused pragmas, modify haddock comment on parser

* working but need to clean lots of little things and add more tests

* uncomment completions functions and tests (was trying to see why the test timeout), merge textedits to get around lsp-test applying text edits in reverse order, inserting pragma between lines fixes, some tests

* add line splitting tests, fix line splitting errors and among other things, add docs

* change comments, add cpp for setting use_pos_prags bit in PState

* add safeImportsOn to compat, fix ghc versions

* fix compat

* fix compat

* fix compat 3

* fix compat 4

* fix compat 5

* fix test

* fix compat 6

* add back some tests and investigate #2375 later

Co-authored-by: Javier Neira <[email protected]>
drsooch pushed a commit to drsooch/haskell-language-server that referenced this issue Dec 3, 2021
@eddiemundo @jneira @drsooch
Fix extension pragma inserted below ghc options pragma haskell#2364 (h…
7a00e43 
…askell#2392)

* new parser for stuff before first declaration

* remove unused pragmas, modify haddock comment on parser

* working but need to clean lots of little things and add more tests

* uncomment completions functions and tests (was trying to see why the test timeout), merge textedits to get around lsp-test applying text edits in reverse order, inserting pragma between lines fixes, some tests

* add line splitting tests, fix line splitting errors and among other things, add docs

* change comments, add cpp for setting use_pos_prags bit in PState

* add safeImportsOn to compat, fix ghc versions

* fix compat

* fix compat

* fix compat 3

* fix compat 4

* fix compat 5

* fix test

* fix compat 6

* add back some tests and investigate haskell#2375 later

Co-authored-by: Javier Neira <[email protected]>
@eddiemundo
Copy link
Collaborator

This no longer happens for some reason... probably can close.

@maralorn
Copy link
Contributor Author

That’s okay with me. I might try again at some point and will just open a new issue if I encounter this problem again.

@jneira
Copy link
Member

jneira commented Dec 10, 2021 •
edited
Loading

@eddiemundo i think you should be able to close it yourself, ping me it it is not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-pragmas-plugin os: nixos type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jneira @eddiemundo @maralorn