Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jacobian Methods #1342

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Fix Jacobian Methods #1342

merged 6 commits into from
Aug 17, 2023

Conversation

wdu9
Copy link
Collaborator

@wdu9 wdu9 commented Aug 17, 2023

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@wdu9 wdu9 requested review from alanlujan91 and Mv77 August 17, 2023 15:41
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 97.82% and project coverage change: +0.04% 🎉

Comparison is base (4f644bf) 72.64% compared to head (0cdecbd) 72.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   72.64%   72.68%   +0.04%     
==========================================
  Files          78       78              
  Lines       13028    13052      +24     
==========================================
+ Hits         9464     9487      +23     
- Misses       3564     3565       +1     
Files Changed Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 87.23% <97.77%> (+0.18%) ⬆️
...nsumptionSaving/tests/test_IndShockConsumerType.py 79.01% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mv77
Copy link
Contributor

Mv77 commented Aug 17, 2023

Thanks @wdu9 ,

Can you just edit the changelog? After that, I'll merge

@Mv77 Mv77 merged commit b18c71f into econ-ark:master Aug 17, 2023
@Mv77
Copy link
Contributor

Mv77 commented Aug 17, 2023

Ok, merging in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants