-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downstream ci #72
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0a0557e
Add to downstream-ci
iainrussell 16adee6
Rename previous ci to ci-single
iainrussell 6b5b67c
Add to downstream-ci
iainrussell 89dab8d
Add to downstream-ci
iainrussell f4fdb60
Add to downstream-ci
iainrussell b7e887a
Add to downstream-ci
iainrussell 21004a0
Add to downstream-ci - disable code coverage
iainrussell a143617
Add to downstream-ci - disable code coverage
iainrussell 2452331
Disable notify
wdeconinck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
dependency_branch: develop | ||
parallelism_factor: 8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
build: | ||
modules: | ||
- ninja | ||
parallel: 64 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: ci-single | ||
|
||
# Controls when the workflow will run | ||
on: | ||
|
||
# Trigger the workflow on all pushes, except on tag creation | ||
push: | ||
branches: | ||
- '**' | ||
tags-ignore: | ||
- '**' | ||
|
||
# Trigger the workflow on all pull requests | ||
pull_request: ~ | ||
|
||
# Allow workflow to be dispatched on demand | ||
workflow_dispatch: ~ | ||
|
||
jobs: | ||
|
||
# Calls a reusable CI workflow to build & test the current repository. | ||
# We skip jobs that will result in duplicate artifacts, since the code does not depend on the compiler. | ||
ci: | ||
name: ci | ||
uses: ecmwf-actions/reusable-workflows/.github/workflows/ci.yml@v2 | ||
with: | ||
skip_matrix_jobs: | | ||
[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,97 @@ | ||
name: ci | ||
|
||
# Controls when the workflow will run | ||
on: | ||
|
||
# Trigger the workflow on all pushes, except on tag creation | ||
# Trigger the workflow on push to master or develop, except tag creation | ||
push: | ||
branches: | ||
- '**' | ||
- "master" | ||
- "develop" | ||
tags-ignore: | ||
- '**' | ||
- "**" | ||
paths-ignore: | ||
- "docs/**" | ||
- "bamboo/**" | ||
- "README.rst" | ||
|
||
# Trigger the workflow on all pull requests | ||
# Trigger the workflow on pull request | ||
pull_request: ~ | ||
|
||
# Allow workflow to be dispatched on demand | ||
# Trigger the workflow manually | ||
workflow_dispatch: ~ | ||
|
||
# Trigger after public PR approved for CI | ||
pull_request_target: | ||
types: [labeled] | ||
|
||
|
||
jobs: | ||
# Run CI including downstream packages on self-hosted runners | ||
downstream-ci: | ||
name: downstream-ci | ||
if: ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }} | ||
uses: ecmwf-actions/downstream-ci/.github/workflows/downstream-ci.yml@main | ||
with: | ||
ecbuild: ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }} | ||
codecov_upload: false | ||
secrets: inherit | ||
|
||
# Calls a reusable CI workflow to build & test the current repository. | ||
# We skip jobs that will result in duplicate artifacts, since the code does not depend on the compiler. | ||
ci: | ||
name: ci | ||
uses: ecmwf-actions/reusable-workflows/.github/workflows/ci.yml@v2 | ||
# Run CI of private downstream packages on self-hosted runners | ||
private-downstream-ci: | ||
name: private-downstream-ci | ||
needs: [downstream-ci] | ||
if: (success() || failure()) && ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }} | ||
runs-on: ubuntu-latest | ||
permissions: | ||
pull-requests: write | ||
steps: | ||
- name: Dispatch private downstream CI | ||
uses: ecmwf-actions/dispatch-private-downstream-ci@v1 | ||
with: | ||
token: ${{ secrets.GH_REPO_READ_TOKEN }} | ||
owner: ecmwf-actions | ||
repository: private-downstream-ci | ||
event_type: downstream-ci | ||
payload: '{"ecbuild": "ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}"}' | ||
|
||
# Build downstream packages on HPC | ||
downstream-ci-hpc: | ||
name: downstream-ci-hpc | ||
if: ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }} | ||
uses: ecmwf-actions/downstream-ci/.github/workflows/downstream-ci-hpc.yml@main | ||
with: | ||
skip_matrix_jobs: | | ||
[email protected] | ||
ecbuild: ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }} | ||
secrets: inherit | ||
|
||
# Run CI of private downstream packages on HPC | ||
private-downstream-ci-hpc: | ||
name: private-downstream-ci-hpc | ||
needs: [downstream-ci-hpc] | ||
if: (success() || failure()) && ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }} | ||
runs-on: ubuntu-latest | ||
permissions: | ||
pull-requests: write | ||
steps: | ||
- name: Dispatch private downstream CI | ||
uses: ecmwf-actions/dispatch-private-downstream-ci@v1 | ||
with: | ||
token: ${{ secrets.GH_REPO_READ_TOKEN }} | ||
owner: ecmwf-actions | ||
repository: private-downstream-ci | ||
event_type: downstream-ci-hpc | ||
payload: '{"ecbuild": "ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}","skip_matrix_jobs": "nvidia-22.11"}' | ||
|
||
# DISABLED FOR NOW UNTIL REPO IS SET UP FOR THIS | ||
# notify: | ||
# runs-on: ubuntu-latest | ||
# needs: | ||
# - downstream-ci | ||
# - private-downstream-ci | ||
# - downstream-ci-hpc | ||
# - private-downstream-ci-hpc | ||
# if: ${{ always() && !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }} | ||
# steps: | ||
# - name: Trigger Teams notification | ||
# uses: ecmwf-actions/notify-teams@v1 | ||
# with: | ||
# incoming_webhook: ${{ secrets.MS_TEAMS_INCOMING_WEBHOOK }} | ||
# needs_context: ${{ toJSON(needs) }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file so complicated compared to other packages ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no more complicated than the equivalent in eccodes - it has to run 4 things: downstream-ci on Linux runners and on HPC (2 things) plus the same for the private downstream-ci (because ecbuild is also used in packages that are private).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! thanks!