Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream ci #72

Merged
merged 9 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/ci-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dependency_branch: develop
parallelism_factor: 8
5 changes: 5 additions & 0 deletions .github/ci-hpc-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
build:
modules:
- ninja
parallel: 64

28 changes: 28 additions & 0 deletions .github/workflows/ci-single.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: ci-single

# Controls when the workflow will run
on:

# Trigger the workflow on all pushes, except on tag creation
push:
branches:
- '**'
tags-ignore:
- '**'

# Trigger the workflow on all pull requests
pull_request: ~

# Allow workflow to be dispatched on demand
workflow_dispatch: ~

jobs:

# Calls a reusable CI workflow to build & test the current repository.
# We skip jobs that will result in duplicate artifacts, since the code does not depend on the compiler.
ci:
name: ci
uses: ecmwf-actions/reusable-workflows/.github/workflows/ci.yml@v2
with:
skip_matrix_jobs: |
[email protected]
97 changes: 83 additions & 14 deletions .github/workflows/ci.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file so complicated compared to other packages ci?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no more complicated than the equivalent in eccodes - it has to run 4 things: downstream-ci on Linux runners and on HPC (2 things) plus the same for the private downstream-ci (because ecbuild is also used in packages that are private).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! thanks!

Original file line number Diff line number Diff line change
@@ -1,28 +1,97 @@
name: ci

# Controls when the workflow will run
on:

# Trigger the workflow on all pushes, except on tag creation
# Trigger the workflow on push to master or develop, except tag creation
push:
branches:
- '**'
- "master"
- "develop"
tags-ignore:
- '**'
- "**"
paths-ignore:
- "docs/**"
- "bamboo/**"
- "README.rst"

# Trigger the workflow on all pull requests
# Trigger the workflow on pull request
pull_request: ~

# Allow workflow to be dispatched on demand
# Trigger the workflow manually
workflow_dispatch: ~

# Trigger after public PR approved for CI
pull_request_target:
types: [labeled]


jobs:
# Run CI including downstream packages on self-hosted runners
downstream-ci:
name: downstream-ci
if: ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
uses: ecmwf-actions/downstream-ci/.github/workflows/downstream-ci.yml@main
with:
ecbuild: ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}
codecov_upload: false
secrets: inherit

# Calls a reusable CI workflow to build & test the current repository.
# We skip jobs that will result in duplicate artifacts, since the code does not depend on the compiler.
ci:
name: ci
uses: ecmwf-actions/reusable-workflows/.github/workflows/ci.yml@v2
# Run CI of private downstream packages on self-hosted runners
private-downstream-ci:
name: private-downstream-ci
needs: [downstream-ci]
if: (success() || failure()) && ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- name: Dispatch private downstream CI
uses: ecmwf-actions/dispatch-private-downstream-ci@v1
with:
token: ${{ secrets.GH_REPO_READ_TOKEN }}
owner: ecmwf-actions
repository: private-downstream-ci
event_type: downstream-ci
payload: '{"ecbuild": "ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}"}'

# Build downstream packages on HPC
downstream-ci-hpc:
name: downstream-ci-hpc
if: ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
uses: ecmwf-actions/downstream-ci/.github/workflows/downstream-ci-hpc.yml@main
with:
skip_matrix_jobs: |
[email protected]
ecbuild: ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}
secrets: inherit

# Run CI of private downstream packages on HPC
private-downstream-ci-hpc:
name: private-downstream-ci-hpc
needs: [downstream-ci-hpc]
if: (success() || failure()) && ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- name: Dispatch private downstream CI
uses: ecmwf-actions/dispatch-private-downstream-ci@v1
with:
token: ${{ secrets.GH_REPO_READ_TOKEN }}
owner: ecmwf-actions
repository: private-downstream-ci
event_type: downstream-ci-hpc
payload: '{"ecbuild": "ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}","skip_matrix_jobs": "nvidia-22.11"}'

# DISABLED FOR NOW UNTIL REPO IS SET UP FOR THIS
# notify:
# runs-on: ubuntu-latest
# needs:
# - downstream-ci
# - private-downstream-ci
# - downstream-ci-hpc
# - private-downstream-ci-hpc
# if: ${{ always() && !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
# steps:
# - name: Trigger Teams notification
# uses: ecmwf-actions/notify-teams@v1
# with:
# incoming_webhook: ${{ secrets.MS_TEAMS_INCOMING_WEBHOOK }}
# needs_context: ${{ toJSON(needs) }}
Loading