Add downstream ci #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to downstream-ci
marcosbento
force-pushed
the
feature/add-to-downstream-ci
branch
from
7d09ab2
to
a143617
Compare
wdeconinck
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Why is this file so complicated compared to other packages ci?
There was a problem hiding this comment.
It's no more complicated than the equivalent in eccodes - it has to run 4 things: downstream-ci on Linux runners and on HPC (2 things) plus the same for the private downstream-ci (because ecbuild is also used in packages that are private).
wdeconinck
reviewed
Nov 12, 2024
.github/workflows/ci.yml
Outdated
| event_type: downstream-ci-hpc | ||
| payload: '{"ecbuild": "ecmwf/ecbuild@${{ github.event.pull_request.head.sha || github.sha }}","skip_matrix_jobs": "nvidia-22.11"}' | ||
|
|
||
| notify: |
There was a problem hiding this comment.
The notify is failing. Perhaps we should disable it for now.
wdeconinck
approved these changes
Nov 12, 2024
wdeconinck
added a commit
that referenced
this pull request
Nov 18, 2024
* gh/release/3.9.0: Version 3.9.0 Add downstream ci (#72) Fix ecbuild_disable_unused_feature Add workflow to check release version is correct (#54) Add ecbuild_override_compiler_flags macro Add utility to initialise overrideable compiler flags Add utility to purge compiler flags for a given language Add tests according to Github issue #65 Enable distinction between enabled/disabled features Update ci action to v2 (#68) Stricter match condition for _fail strings (#64) CPP out LOC calls for NAG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.