[vscode] support CommentThread state property #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmaeder
reviewed
Apr 20, 2023
packages/plugin-ext/src/main/browser/comments/comment-thread-widget.tsx
Outdated
Show resolved
Hide resolved
|
@rschnekenbu do we have an issue for the problems with the menus you mentioned? If not, could you open one, please? |
The issue eclipse-theia#12452 has been created to track those problems about menus. |
AlexandraBuzila
approved these changes
Apr 25, 2023
solves eclipse-theia#12231 Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
issues/12231
branch
from
830e637 to
7d085e2
Compare
|
Closed in favor of eclipse-theia PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add Comment#state optional property
This adds the state optional property from Comment to improve vscode api coverage. It also displays the state in the Comment Thread widget
Fixes eclipse-theia#12231
Contributed on behalf of ST Microelectronics
How to test
Note: there are currently some issues with menus, since theia 1.28.0. This is due to eclipse-theia#11290, integrated in 1.28.0. Prior to this change, the comment sample works on theia 1.27.0. So to test this change, I cherry-picked my commit on top of 1.27.0 tag.
This is the same case as for PR eclipse-theia#12007.
Review checklist
Reminder for reviewers