Adding timestamp to comment. fixes #11702 #12007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
reviewed
Dec 19, 2022
kittaakos
reviewed
Dec 19, 2022
packages/plugin-ext/src/main/browser/comments/comment-thread-widget.tsx
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/comments/comment-thread-widget.tsx
Outdated
Show resolved
Hide resolved
rschnekenbu
force-pushed
the
issues/11702
branch
from
e29c860 to
376dbca
Compare
|
@vince-fugnitto, with the new version, I get a green flag on the vscode-theia-comparator: Note: I also updated the comment vsix extension sample archive, which has the same typo issue. |
kittaakos
reviewed
Dec 20, 2022
packages/plugin-ext/src/main/browser/comments/comment-thread-widget.tsx
Outdated
Show resolved
Hide resolved
rschnekenbu
force-pushed
the
issues/11702
branch
from
376dbca to
5d615cd
Compare
Contributed on behalf of STMicroelectronics Fixes eclipse-theia#11702
rschnekenbu
force-pushed
the
issues/11702
branch
from
5d615cd to
6895086
Compare
kittaakos
approved these changes
Dec 22, 2022
|
@vince-fugnitto Are you fine with merging this? |
1 task
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add Comment#timestamp optional property
This adds the timeStamp optional property from Comment to improve vscode api coverage. It also displays the timestamp of each comments in the Comment Thread widget
Fixes #11702
Contributed on behalf of ST Microelectronics
How to test
Note: there are currently some issues with menus, since theia 1.28.0. This is due to #11290, integrated in 1.28.0. Prior to this change, the comment sample works on theia 1.27.0. So to test this change, I cherry-picked my commit on top of 1.27.0 tag. Please see also #11730 for this menu issues.
Install forked extension vscode-comment-api-example-0.0.1.zip
vsix file
Create a comment using the side bar while comparing 2 test files.
The timestamp should be displayed along the user name.
Review checklist
Reminder for reviewers