Fix some API inconsistencies related to web views #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the extension: And here's the source: |
lucas-koehler
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Code changes look good to me and I could verify the behavior with the provided test extension.
For the upstream PR, please don't forget to add a changelog entry including the attribution suffix - Contributed on behalf of STMicroelectronics (you can see an example in the CHANGELOG.md)
Fixes eclipse-theia#12087 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
force-pushed
the
12087_fix_webview_api
branch
from
b018290
to
5fb5f93
Compare
|
Closing in favor of eclipse-theia#12091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-theia#12087
Contributed on behalf of STMicroelectronics
Signed-off-by: Thomas Mäder [email protected]
What it does
Fixes a typing difference in
createWebViewPanelas well as support for filtering command links via an array of command id's passed toenableCommandUris.How to test
The attached extension opens three web views at startup: one where the
openFolderlink works, butopenFileis disabled, one where command links are generally enabled and one where they are generally turned off.Review checklist
Reminder for reviewers