Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some inconsistencies in webview VS Code API #12087

Closed
tsmaeder opened this issue Jan 19, 2023 · 0 comments · Fixed by #12091
Closed

Fix some inconsistencies in webview VS Code API #12087

tsmaeder opened this issue Jan 19, 2023 · 0 comments · Fixed by #12091
Assignees
@tsmaeder
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

There are some inconsistencies in our webview API implementation that show up as "partial" implementations in the compatibility report, namely:

  • WebViewOptions.enableCommandUris can be an array of strings as well as a boolean
  • `window.createWebViewPanel(...) uses an ad-hoc type instead of WebviewPanelShowOptions
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility webviews issues related to webviews labels Jan 19, 2023
@tsmaeder tsmaeder self-assigned this Jan 19, 2023
tsmaeder added a commit to tsmaeder/theia that referenced this issue Jan 19, 2023
@tsmaeder
Fix some API inconsistencies related to web views
b018290 
Fixes eclipse-theia#12087

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Jan 19, 2023
Closed
1 task
@tsmaeder tsmaeder changed the title Fix some inconsistencies in webviwe VS Code API Fix some inconsistencies in webview VS Code API Jan 19, 2023
tsmaeder added a commit to tsmaeder/theia that referenced this issue Jan 20, 2023
@tsmaeder
Fix some API inconsistencies related to web views
5fb5f93 
Fixes eclipse-theia#12087

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Jan 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
No milestone
1 participant
@tsmaeder