Add autopaho tests and resolve issues identified by them. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of continuing work on session state persistence, this adds tests to autopaho that will provide a base for testing coming changes. An option to use a custom connection function was also introduced (mainly to simplify tests). The tests identified a few issues which have been resolved: * `errChan` (`autopaho.NewConnection`) may lead to leaked goroutine (due to the timing of calls to `client.OnClientError`) * The way `autopaho` set logging handlers led to a data race. Closes #155
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of continuing work on session state persistence, this adds tests to autopaho that will provide a base for testing coming changes. An option to use a custom connection function was also introduced (mainly to simplify tests). The tests identified a few issues which have been resolved:
errChan(autopaho.NewConnection) may lead to leaked goroutine (due to the timing of calls toclient.OnClientError)autopahoset logging handlers led to a data race.Closes #155