Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Disconnect consume pending ErrChan #154

Closed
wants to merge 1 commit into from

Conversation

phcurtis2
Copy link

When a disconnect occurs avoid goroutine leak by consuming errChan.

Do not create a Pull Request without creating an issue first

The design of your solution to the problem should be discussed and agreed in an issue before submitting the PR

ECA - Eclipse Contributer Agreement

Ensure you have a valid, signed ECA for the email address associated with your Github account (or you sign off your PR with an ECA'd address)

Please provide enough information so that others can review your pull request:

Testing

Any code changes should have accompanying tests.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes.

When a disconnect occurs avoid goroutine leak by consuming errChan.
@MattBrittan
Copy link
Contributor

Unfortunately I will not be able to accept this pull without a ECA (see the checks). However, as per the comments, I'm leaning towards another solution.

@MattBrittan
Copy link
Contributor

I'll close this PR as I have, as per comments on issue #155, resolved this in a different way via PR #156. Thanks very much for raising the PR, just luck of the draw that I happened to be working on the same thing as part of a larger change.

@MattBrittan MattBrittan closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants