On Disconnect consume pending ErrChan #154
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a disconnect occurs avoid goroutine leak by consuming errChan.
Do not create a Pull Request without creating an issue first
The design of your solution to the problem should be discussed and agreed in an issue before submitting the PR
ECA - Eclipse Contributer Agreement
Ensure you have a valid, signed ECA for the email address associated with your Github account (or you sign off your PR with an ECA'd address)
Please provide enough information so that others can review your pull request:
Testing
Any code changes should have accompanying tests.
Closing issues
Put
closes #XXXX
in your comment to auto-close the issue that your PR fixes.