Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bnd.bnd to allow this bundle manifest to work with EE 10 #311

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Update bnd.bnd to allow this bundle manifest to work with EE 10 #311

merged 1 commit into from
Nov 8, 2022

Conversation

Emily-Jiang
Copy link
Member

@Emily-Jiang Emily-Jiang commented Nov 7, 2022 •
edited
Loading

Fixes: #310

@Emily-Jiang Emily-Jiang mentioned this pull request Nov 7, 2022
Closed
@sberyozkin
Copy link
Contributor

Thanks Emily, looks like we are OK here, as this PR only allows MP JWT 2.1 to run in EE10 containers, but I'd like to wait a bit in case Roberto @radcortez or David @dblevins have some concerns

sberyozkin
sberyozkin approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me merge it now, if anything relates comes up before the final release we can fix it but hopefully it won't be needed

@sberyozkin sberyozkin merged commit 46a93ec into eclipse:master Nov 8, 2022
@Emily-Jiang
Copy link
Member Author

@sberyozkin we need to restage the final release. Do you want to do it or you want me to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@teddyjtorres teddyjtorres Awaiting requested review from teddyjtorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API 2.1 excludes EE 10 versions in Manifest
2 participants
@Emily-Jiang @sberyozkin