-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 2.1 excludes EE 10 versions in Manifest #310
Comments
@Emily-Jiang Hi, what is the right fix here such that it is consistent with other MP specs ? I believe OpenLiberty also has some OSGI constraints ? |
Since MP JWT 2.1 works with Jakarta EE 9.1 and it uses the "Compile low, run high", this spec primarily works with EE 9.1 but also works with Jakarta EE 10 Core Profile. In Open Liberty, we did manifest rewrite to allow the bundlised version working with EE 10. I think we can fix this in the bnd.bnd to make the version range inculde EE 10 range if necessary. |
I agree that it should be open to allow "compile low, run high", but it doesn't seem consistent with the discussion on the ML when @dblevins brought this up. If we enforce a minimum on EE 10 at the platform level, then all platform specifications should also enforce the minimum requirements. |
It does operate on "compile low, run high". However, the manifest was not opened up for EE 10, as normally major version changes could break things. Since we have tested JWT 2.1 works with EE 10, its manifest can be relaxed to embrace CDI 4.0. I have done a PR to fix this. |
@sberyozkin @arjantijms I have provided a PR #311 to fix this. |
Incidentally, we have a manifest rewriter available in GlassFish as well. But using it always feels like a hack, and if possible we like to avoid using it. |
The Manifest of the latest 2.1 API (RC6) contains the following import line:
This will fail on EE 10 OSGi environments such as GlassFish 7:
The text was updated successfully, but these errors were encountered: