Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add ConfigBuilder#withConverter(Class, int, Converter) #298

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Dec 20, 2017

  • This method can be used to provide converter using lambda expressions
  • add TCK test to check lambda converters
  • add TCK text to check priority of lambda and custom converters

Signed-off-by: Jeff Mesnil [email protected]

* This method can be used to provide converter using lambda expressions
* add TCK test to check lambda converters
* add TCK text to check priority of lambda and custom converters

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil
Copy link
Contributor Author

jmesnil commented Dec 20, 2017

@Emily-Jiang this is the mp-config port of the withConverter method.

However, the project can not be built with that change:

[INFO] --- bnd-baseline-maven-plugin:3.5.0:baseline (baseline) @ microprofile-config-api ---
[INFO] Automatically determining the baseline version for org.eclipse.microprofile.config:microprofile-config-api:jar:1.2-SNAPSHOT using repositories [jboss-community-repository (http://repository.jboss.org/nexus/content/groups/public/, default, releases), eclipse.microprofile (https://repo.eclipse.org/content/groups/microprofile/, default, releases+snapshots), central (https://repo.maven.apache.org/maven2, default, releases)]
[INFO] The baseline version was found to be 1.1
[ERROR] Baseline mismatch for package org.eclipse.microprofile.config.spi, MAJOR change. Current is 1.1.0, repo is 1.1.0, suggest 2.0.0 or 1.1.0
[ERROR] The bundle version change (1.1.0 to 1.2.0) is too low, the new version must be at least 2.0.0

It seems that adding a method in the ConfigBuilder SPI require a major version change.

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jmesnil !

@Emily-Jiang Emily-Jiang merged commit d1a29a0 into eclipse:master Dec 20, 2017
@Emily-Jiang
Copy link
Member

close #205 #126

@johnament
Copy link
Contributor

@jmesnil to avoid implementor breakage, can you make this a default no-op method?

Emily-Jiang added a commit that referenced this pull request Dec 20, 2017
Signed-off-by: Emily Jiang <[email protected]>
Emily-Jiang added a commit that referenced this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants