Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatic way to add converters #205

Closed
johnament opened this issue Jul 29, 2017 · 4 comments
Closed

Programmatic way to add converters #205

johnament opened this issue Jul 29, 2017 · 4 comments
Milestone

Comments

@johnament
Copy link
Contributor

#125 mentions a CDI way to add converters.

However, I just need a plain way to register extra converters. It should take type into account, as it's possible to use the same converter for base classes without needing multiple registrations.

@struberg
Copy link
Contributor

The whole Config is immutable by design.
Can you think about a way to add a Converter or any other Config component via CDI but still have the Config immutable?

@johnament
Copy link
Contributor Author

I was figuring this applied more to the config builder, or some annotation that could be added that indicated the types the converter supported, e.g. configBuilder.addConverter(type, converter) or saying that the existing addConverter looked for an annotation @Converts(Class...)

@Emily-Jiang
Copy link
Member

@jmesnil will you be able to port the changes from config jsr here?

@Emily-Jiang
Copy link
Member

solved by #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants