Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please enhance JksOptions to support selection of SSL key in keystore using an alias property #3926

Closed
peterwalkley opened this issue May 13, 2021 · 3 comments · Fixed by #3933
Assignees
Labels
Milestone

Comments

@peterwalkley
Copy link

peterwalkley commented May 13, 2021

For context, I asked this question originally for Quarkus (see: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Any.20way.20to.20specify.20SSL.20key.20alias.20when.20using.20a.20keystore.20.3F ) and was asked to raise an issue for a Vert.x change.

There is currently no way to choose the SSL key alias for cases where a java key store may contain more than one key, thus no way to ensure the correct key is used when presenting the server certificate for SSL.

@sberyozkin
Copy link

sberyozkin commented May 13, 2021

Hi @vietj @pmlopes - I can see KeyStoreHelper iterating over aliases so may be KeyStoreOptions (since this is what we use in Quarkus) can get an alias property added ? I guess TrustStoreOptions should also be updated
CC @cescoffier, thanks

@vietj vietj added this to the 4.1.0 milestone May 13, 2021
tsegismont added a commit to tsegismont/vert.x that referenced this issue May 18, 2021
Fixes eclipse-vertx#3926

This can be useful if users don't control the JKS file and it contains
multiple entries.

In this case, the SSL engine chooses the first one by default but it
might not what the user expects.

Signed-off-by: Thomas Segismont <[email protected]>
tsegismont added a commit to tsegismont/vert.x that referenced this issue May 19, 2021
Fixes eclipse-vertx#3926

This can be useful if users don't control the JKS file and it contains
multiple entries.

In this case, the SSL engine chooses the first one by default but it
might not what the user expects.

Signed-off-by: Thomas Segismont <[email protected]>
@sberyozkin
Copy link

Thanks @tsegismont, @vietj

@tsegismont
Copy link
Contributor

tsegismont commented May 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment