Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update EDR negotiation request #186

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

wadahiro
Copy link
Contributor

Description

I noticed that due to the upgrade to EDC 0.4.1 in pull request eclipse-tractusx/tractusx-edc#877, the curl command for EDR negotiation mentioned in the README.md is causing the following error.

[
  {
    "message": "mandatory value 'https://w3id.org/edc/v0.0.1/ns/counterPartyAddress' is missing or it is blank",
    "type": "ValidationFailure",
    "path": "https://w3id.org/edc/v0.0.1/ns/counterPartyAddress",
    "invalidValue": null
  }
]

This pull request addresses the issue by modifying it to align with the schema of the updated EDR negotiation request.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wadahiro

@wolf4ood wolf4ood merged commit 3e4e96c into eclipse-tractusx:main Dec 19, 2023
4 checks passed
@wadahiro wadahiro deleted the fix-doc branch December 20, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants