-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to released data provider chart #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert approval due to failed install
and switch to released data provider chart install issue will be solved by #67
and switch to released data provider chart install issue will be solved by #67
…e-released-provider-chart # Conflicts: # charts/umbrella/Chart.yaml
until install issue is solved by #67 and update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to presumed issue that the umbrella chart was running out of resources during install, I reviewed the tx-data-provider integration more thoroughly.
I noticed that in its current setup, the values file from the tx-data-provider chart and - afterwards when integrated - the values file from the umbrella chart don't perform any kind of overwrite on the subcharts (tractusx-connector, digital-twin-registry, simple-data-backend and vault).
I assume the connection to the subcharts fails because most of them have hyphens in the chart name. I tried to work with aliases in tx-data-provider chart, and that works, so the overwrite from the values file from the tx-data-provider was taken into account but when integrating, the overwrite from the values file of the umbrella still doesn't work.
Note: once the overwrite from the values file from the tx-data-provider works, the dependency to the common chart of Bitnami of the digital-twin-registry causes issues with the postgres setup.
Let's discuss next week how to proceed. Maybe it's better to add the charts for the tx-data-provider directly to the umbrella chart and work with aliases for setting up some charts multiple times, in order to avoid such nested situations.
I did look into it a bit more: Some corrections:
There were to issues at play (all solved here #73):
I recommend to close this PR and merge #73 instead. |
Thanks a lot for the feedback and fixes. |
fix tx-data-provider: - allow provider and consumer being enabled at the same time (relates to #67) - adjust adopter values files and docs chart testing: - split install into shared-services and data-exchange - disable all components in default values file chore(iam): change to imagePullPolicy IfNotPresent
Description
eclipse-tractusx/sig-release#418
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: