Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to released data provider chart #67

Closed
wants to merge 8 commits into from

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Apr 22, 2024

Description

eclipse-tractusx/sig-release#418

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert approval due to failed install

evegufy added a commit that referenced this pull request Apr 24, 2024
and switch to released data provider chart
install issue will be solved by #67
evegufy added a commit that referenced this pull request Apr 24, 2024
and switch to released data provider chart
install issue will be solved by #67
evegufy added a commit that referenced this pull request Apr 24, 2024
until install issue is solved by #67
and update docs
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ds-jhartmann

due to presumed issue that the umbrella chart was running out of resources during install, I reviewed the tx-data-provider integration more thoroughly.

I noticed that in its current setup, the values file from the tx-data-provider chart and - afterwards when integrated - the values file from the umbrella chart don't perform any kind of overwrite on the subcharts (tractusx-connector, digital-twin-registry, simple-data-backend and vault).
I assume the connection to the subcharts fails because most of them have hyphens in the chart name. I tried to work with aliases in tx-data-provider chart, and that works, so the overwrite from the values file from the tx-data-provider was taken into account but when integrating, the overwrite from the values file of the umbrella still doesn't work.

Note: once the overwrite from the values file from the tx-data-provider works, the dependency to the common chart of Bitnami of the digital-twin-registry causes issues with the postgres setup.

Let's discuss next week how to proceed. Maybe it's better to add the charts for the tx-data-provider directly to the umbrella chart and work with aliases for setting up some charts multiple times, in order to avoid such nested situations.

@evegufy
Copy link
Contributor

evegufy commented Apr 29, 2024

Hi @ds-jhartmann

due to presumed issue that the umbrella chart was running out of resources during install, I reviewed the tx-data-provider integration more thoroughly.

I noticed that in its current setup, the values file from the tx-data-provider chart and - afterwards when integrated - the values file from the umbrella chart don't perform any kind of overwrite on the subcharts (tractusx-connector, digital-twin-registry, simple-data-backend and vault). I assume the connection to the subcharts fails because most of them have hyphens in the chart name. I tried to work with aliases in tx-data-provider chart, and that works, so the overwrite from the values file from the tx-data-provider was taken into account but when integrating, the overwrite from the values file of the umbrella still doesn't work.

Note: once the overwrite from the values file from the tx-data-provider works, the dependency to the common chart of Bitnami of the digital-twin-registry causes issues with the postgres setup.

Let's discuss next week how to proceed. Maybe it's better to add the charts for the tx-data-provider directly to the umbrella chart and work with aliases for setting up some charts multiple times, in order to avoid such nested situations.

I did look into it a bit more:

Some corrections:

  • the values file from the tx-data-provider chart does perform the expected overwrite when installing the tx-data-provider directly
  • the values file from the umbrella chart does perform the expected overwrite if only one, dataconsumer or dataprovider, is enabled (even though dataprovider did run into the following error if the password for the dtr database was not set Error: INSTALLATION FAILED: template: umbrella/charts/dataprovider/charts/digital-twin-registry/templates/registry/postgres-init.yaml:35:63: executing "umbrella/charts/dataprovider/charts/digital-twin-registry/templates/registry/postgres-init.yaml" at <b64enc>: invalid value; expected string)
  • the digital-twin-registry chart doesn't have a direct dependency to the common chart of bitnami

There were to issues at play (all solved here #73):

  • dataconsumer and dataprovider couldn't be enabled at the same time without running into an error related to the existingSecret override in the digital-twin-registry chart, I changed to a working setup 9376e25
  • the install of the umbrella chart was running out of resources with the tx-data-provider components integrated and enabled: due to that I reworked the chart testing concept: chore: rework chart testing and tx-data-provider #73

I recommend to close this PR and merge #73 instead.

@ds-jhartmann
Copy link
Contributor Author

Hi @ds-jhartmann
due to presumed issue that the umbrella chart was running out of resources during install, I reviewed the tx-data-provider integration more thoroughly.
I noticed that in its current setup, the values file from the tx-data-provider chart and - afterwards when integrated - the values file from the umbrella chart don't perform any kind of overwrite on the subcharts (tractusx-connector, digital-twin-registry, simple-data-backend and vault). I assume the connection to the subcharts fails because most of them have hyphens in the chart name. I tried to work with aliases in tx-data-provider chart, and that works, so the overwrite from the values file from the tx-data-provider was taken into account but when integrating, the overwrite from the values file of the umbrella still doesn't work.
Note: once the overwrite from the values file from the tx-data-provider works, the dependency to the common chart of Bitnami of the digital-twin-registry causes issues with the postgres setup.
Let's discuss next week how to proceed. Maybe it's better to add the charts for the tx-data-provider directly to the umbrella chart and work with aliases for setting up some charts multiple times, in order to avoid such nested situations.

I did look into it a bit more:

Some corrections:

  • the values file from the tx-data-provider chart does perform the expected overwrite when installing the tx-data-provider directly
  • the values file from the umbrella chart does perform the expected overwrite if only one, dataconsumer or dataprovider, is enabled (even though dataprovider did run into the following error if the password for the dtr database was not set Error: INSTALLATION FAILED: template: umbrella/charts/dataprovider/charts/digital-twin-registry/templates/registry/postgres-init.yaml:35:63: executing "umbrella/charts/dataprovider/charts/digital-twin-registry/templates/registry/postgres-init.yaml" at <b64enc>: invalid value; expected string)
  • the digital-twin-registry chart doesn't have a direct dependency to the common chart of bitnami

There were to issues at play (all solved here #73):

  • dataconsumer and dataprovider couldn't be enabled at the same time without running into an error related to the existingSecret override in the digital-twin-registry chart, I changed to a working setup 9376e25
  • the install of the umbrella chart was running out of resources with the tx-data-provider components integrated and enabled: due to that I reworked the chart testing concept: chore: rework chart testing and tx-data-provider #73

I recommend to close this PR and merge #73 instead.

Thanks a lot for the feedback and fixes.
Closing this PR since it will be fixed with #73

evegufy added a commit that referenced this pull request Apr 29, 2024
fix tx-data-provider: 
- allow provider and consumer being enabled at the same time (relates to #67)
- adjust adopter values files and docs

chart testing: 
- split install into shared-services and data-exchange
- disable all components in default values file

chore(iam): change to imagePullPolicy IfNotPresent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants