Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change edc-miw-keycloak-secret in tx-data-provider #130

Closed
evegufy opened this issue Oct 22, 2024 · 0 comments · Fixed by #132
Closed

Change edc-miw-keycloak-secret in tx-data-provider #130

evegufy opened this issue Oct 22, 2024 · 0 comments · Fixed by #132
Assignees
@mgarciaLKS @CDiezRodriguez
Labels
enhancement New feature or request

Comments

@evegufy
Copy link
Contributor

evegufy commented Oct 22, 2024 •
edited
Loading

Description

The name suggests that the secret / secret alias is the client secret in centralidp Keycloak when using the Managed Identity Wallet (MIW).

https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/values.yaml#L36
https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/templates/post-install-vault-setup.yaml#L58

This can be confusing because, since since R2405, MIW is no longer the wallet, see note for more information.

It should be renamed because we use it now with together with the IATP mock and the SSI DIM Wallet Stub.

I suggest to rename it to edc-wallet-secret.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgarciaLKS mgarciaLKS

@CDiezRodriguez CDiezRodriguez

Labels
enhancement New feature or request
Projects
Umbrella Helm Chart
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: change edc-miw-keycloak-secret in tx-data-provider CDiezRodriguez/tractus-x-umbrella
3 participants
@evegufy @mgarciaLKS @CDiezRodriguez