-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SSI DIM Wallet Stub #125
feat: add SSI DIM Wallet Stub #125
Conversation
Gracias @CDiezRodriguez y @mgarciaLKS por preparar este PR ;) Hablamos el lunes Un saludo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good in general!
Hi @CDiezRodriguez I'd add you as Contributor to Eclipse Tractus-X so that it's possible to request your review to a PR, it that ok for you? |
That's awesome, @evegufy. Thank you. |
I invited you. |
Hi @CDiezRodriguez do you have some curl commands with which you tested the data exchange which you could provide? |
Hi @evegufy, |
@evegufy The test that is failing is value-test-data-exchange.yaml, which uses the iatp-mock. Should I create a new test or edit that one? |
that's a good point which reminds me of a related topic, now that the data exchange - besides the onboarding in the portal - is tested successfully: I'd like the dim wallet stub to be the "default wallet", not the iatp mock anymore, because the stub is just the move sustainable solution, enabling dynamic config and enabling also portal processes (the iatp mock didn't support the portal processes up to now, see note. Let me explain it using the directory structure:
What do you think? |
…ta-provider and dataConsumer
…ta-provider and dataConsumer 2
…ta-provider and dataConsumer 3
@saudkhan116 will test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU @CDiezRodriguez
Description
This pull request adds the SSI DIM Wallet Stub to the umbrella chart.
It was proposed by my co-worker @mgarciaLKS during the meeting on October 30th, and the work has been carried out by both @mgarciaLKS and myself with his approval.
For correct operation, the portal must be updated to version 2.2.0, which we have tested successfully.
Closes #122
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: