Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SSI DIM Wallet Stub #125

Merged

Conversation

CDiezRodriguez
Copy link
Contributor

@CDiezRodriguez CDiezRodriguez commented Oct 8, 2024

Description

This pull request adds the SSI DIM Wallet Stub to the umbrella chart.
It was proposed by my co-worker @mgarciaLKS during the meeting on October 30th, and the work has been carried out by both @mgarciaLKS and myself with his approval.
For correct operation, the portal must be updated to version 2.2.0, which we have tested successfully.

Closes #122

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@mgarciaLKS mgarciaLKS requested a review from evegufy October 8, 2024 12:20
@matbmoser
Copy link
Contributor

Gracias @CDiezRodriguez y @mgarciaLKS por preparar este PR ;)
Voy a probar con mi colega a ver si todo funciona bien con v24.08 :)

Hablamos el lunes

Un saludo

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good in general!

charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
@evegufy
Copy link
Contributor

evegufy commented Oct 22, 2024

Hi @CDiezRodriguez I'd add you as Contributor to Eclipse Tractus-X so that it's possible to request your review to a PR, it that ok for you?

@CDiezRodriguez
Copy link
Contributor Author

That's awesome, @evegufy. Thank you.

@evegufy
Copy link
Contributor

evegufy commented Oct 22, 2024

That's awesome, @evegufy. Thank you.

I invited you.

charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange-stub.yaml Outdated Show resolved Hide resolved
@evegufy
Copy link
Contributor

evegufy commented Oct 23, 2024

Hi @CDiezRodriguez do you have some curl commands with which you tested the data exchange which you could provide?
The ones which I have locally appear to be outdated. Thank you!

@CDiezRodriguez
Copy link
Contributor Author

Hi @evegufy,
Attached is the postman I use, I got it from mxd and made some changes to adapt it.
Tractus-X Connector Data Exchange.postman_collection.json

charts/umbrella/Chart.yaml Outdated Show resolved Hide resolved
charts/umbrella/README.md Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
@CDiezRodriguez
Copy link
Contributor Author

@evegufy The test that is failing is value-test-data-exchange.yaml, which uses the iatp-mock. Should I create a new test or edit that one?

@evegufy
Copy link
Contributor

evegufy commented Oct 23, 2024

@evegufy The test that is failing is value-test-data-exchange.yaml, which uses the iatp-mock. Should I create a new test or edit that one?

that's a good point which reminds me of a related topic, now that the data exchange - besides the onboarding in the portal - is tested successfully: I'd like the dim wallet stub to be the "default wallet", not the iatp mock anymore, because the stub is just the move sustainable solution, enabling dynamic config and enabling also portal processes (the iatp mock didn't support the portal processes up to now, see note.

Let me explain it using the directory structure:

charts
└─── umbrella
  └─── values.yaml --> change all config to ssi dim wallet stub
  └─── values-adopter-portal.yaml --> enable for ssi dim wallet stub, most should be already covered by values.yaml, remove values-adopter-data-exchange-stub.yaml, it's no longer needed
  └─── values-adopter-data-exchange.yaml --> enable for ssi dim wallet stub, disable iatp mock, most should be already covered by values.yaml, remove values-adopter-data-exchange-stub.yaml, it's no longer needed
  └─── values-adopter-data-exchange-iatp-mock.yaml --> add values file in case somebody still want to use the iatp mock
└─── values-test-data-exchange.yaml --> enable for ssi dim wallet stub, disable iatp mock
└─── values-test-shared-services-1.yaml --> enable for ssi dim wallet stub, disable iatp mock
└─── values-test-data-exchange-iatp-mock.yaml --> add to test iatp mock

What do you think?

@evegufy evegufy changed the title chore: add SSI DIM Wallet Stub feat: add SSI DIM Wallet Stub Oct 23, 2024
@matbmoser matbmoser marked this pull request as ready for review October 28, 2024 10:15
@matbmoser
Copy link
Contributor

@saudkhan116 will test it

@CDiezRodriguez CDiezRodriguez self-assigned this Oct 28, 2024
@matbmoser matbmoser changed the base branch from main to release/R24.08 October 29, 2024 10:47
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-portal.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values-adopter-data-exchange.yaml Outdated Show resolved Hide resolved
charts/umbrella/Chart.yaml Outdated Show resolved Hide resolved
@matbmoser matbmoser changed the base branch from release/R24.08 to main November 4, 2024 10:25
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU @CDiezRodriguez

@evegufy evegufy merged commit 2fdfd34 into eclipse-tractusx:main Nov 4, 2024
4 checks passed
@CDiezRodriguez CDiezRodriguez deleted the chore/ssi-dim-wallet-stub branch November 12, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate SSI DIM Wallet Stub
6 participants