Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable creation of keycloak-database secret if keycloak is disabled #178

Merged

Conversation

florianrusch-zf
Copy link
Contributor

@florianrusch-zf florianrusch-zf commented Jul 26, 2023

Description

This change disables the creation of the keycloak-database secret if keycloak is disabled at all

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up to date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files

Additional information

@florianrusch-zf florianrusch-zf linked an issue Jul 26, 2023 that may be closed by this pull request
@florianrusch-zf florianrusch-zf marked this pull request as ready for review July 26, 2023 09:19
@florianrusch-zf
Copy link
Contributor Author

@tunacicek @LuLeRoemer the pipelines failed, because the chart version needs to be bumped. How did you handle this in the past? Should each change on the chart contains a version bump? Or do you bump only once if you release a new version? https://github.com/eclipse-tractusx/sldt-digital-twin-registry/actions/runs/5666878597/job/15354511257?pr=178

@tunacicek
Copy link
Contributor

Hi @florianrusch-zf,
yes, on each change in the chart the chart-version needs to be increased. So in this PR, increase the chart version from 0.3.12 to 0.3.13

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit 27ba772 into eclipse-tractusx:main Jul 26, 2023
@florianrusch-zf florianrusch-zf deleted the florianrusch-zf-patch-1 branch July 27, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply database-credentials.yaml only if keycloak is enabled
2 participants