Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply database-credentials.yaml only if keycloak is enabled #179

Closed
florianrusch-zf opened this issue Jul 26, 2023 · 0 comments · Fixed by #178
Closed

Apply database-credentials.yaml only if keycloak is enabled #179

florianrusch-zf opened this issue Jul 26, 2023 · 0 comments · Fixed by #178
Labels
bug Something isn't working

Comments

@florianrusch-zf
Copy link
Contributor

Describe the bug

With the current helm chart the file charts/registry/templates/keycloak/database-credentials.yaml will always be deployed to the cluster - doesn't matter if keycloak was enabled or not.

Additionally, the Secret has a fix name: that means, it's not possible to run two DTRs in the same K8s namespace.

To Reproduce

  1. Deploy the helm chart to a k8s cluster with enableKeycloak: false
  2. Run kubectl get secret keycloak-database-credentials

Expected behavior

If I disable the keycloak setup, I don't want to have anything polluting my environment in context of the keycloak setup.

Possible Implementation

Add an if statement to the template based on the value enableKeycloak. Additionally use a generated name based on the release name (like it's done at the registry/registry-deployment.yaml)

Additional notes

I already created a similary issue recarding the configmap for keycloak: #124

@florianrusch-zf florianrusch-zf added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant