Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply init-script-configmap.yaml only if keycloak is enabled #124

Closed
florianrusch-zf opened this issue May 30, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@florianrusch-zf
Copy link
Contributor

Describe the bug

With the current helm chart the file keycloak/init-script-configmap.yaml will always be deployed to the cluster - doesn't matter if keycloak was enabled or not.

Additionally, the ConfigMap has a fix name: that means, it's not possible to run two DTRs in the same K8s namespace.

To Reproduce

  1. Deploy the helm chart to a k8s cluster with enableKeycloak: false
  2. Run kubectl get cm init-script-vol

Expected behavior

If I disable the keycloak setup, I don't want to have anything polluting my environment in context of the keycloak setup.

Possible Implementation

Add an if statement to the template based on the value enableKeycloak. Additionally use a generated name based on the release name (like it's done at the registry/registry-deployment.yaml)

@tunacicek
Copy link
Contributor

Hi,
fix is done.
Issue will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants