Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add imagePullSecrets #431

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat: add imagePullSecrets #431

merged 2 commits into from
Sep 19, 2024

Conversation

mgarciaLKS
Copy link
Contributor

Description

Enabled more imagepullsecrets to the previous portal PR clipse-tractusx/portal/pull/396

Why

In many organizations, container images are stored in private registries rather than public ones for security and compliance reasons. To pull these images, Kubernetes needs credentials, which are provided via imagePullSecrets. This code dynamically includes the necessary secrets for pulling images, based on the configuration provided in the Helm chart's values file.

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@evegufy evegufy merged commit a9e6279 into eclipse-tractusx:main Sep 19, 2024
5 checks passed
@evegufy
Copy link
Contributor

evegufy commented Sep 19, 2024

@mgarciaLKS thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants