feat: add imagePullScrets #396
Conversation
There was a problem hiding this comment.
@mgarciaLKS thank you for the contribution, looks very good in general!
could you please also add values to the values.yaml with an empty array, an commented out example and an install comment, just as an example, similar to to this value
|
@evegufy Thanks for the feedback. |
|
@evegufy Thanks again for the feedback, I think the proposed changes are very good and have been implemented. |
|
@evegufy You are totally right, my fault, I've gone overboard with the refactoring. Sorry. |
Hi @mgarciaLKS no worries, it's really awesome that you provided this feature 💯 As you asked under "Next Steps" :) this would be a nice feature also for the charts in the following repos: |
previously deployments have been enabled #396
Description
This work has been done together with @gomezbc
The imagePullSecrets field allows you to specify secrets needed to pull Docker images from private repositories.
Why
In many organizations, container images are stored in private registries rather than public ones for security and compliance reasons. To pull these images, Kubernetes needs credentials, which are provided via imagePullSecrets. This code dynamically includes the necessary secrets for pulling images, based on the configuration provided in the Helm chart's values file.
Next Steps
Would it be interesting to add this implementation to other tractus-x charts?
Checklist
Please delete options that are not relevant.