-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduced field of customer contact in service #1214
base: main
Are you sure you want to change the base?
feat: introduced field of customer contact in service #1214
Conversation
89cb552
to
7152151
Compare
bc55cee
to
6afcde5
Compare
6afcde5
to
f2d8b82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check regex length condition once again
6c7561b
to
13fe166
Compare
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phone number check
71776a2
to
82811f9
Compare
Quality Gate passedIssues Measures |
Description
Introduced new input field for user contact in
Register New Service
and also made changes to display it inServiceDetail
andValid and Publish
at last step ofRegister New Service
.Changelog entry:
Why
Previously, we were displaying the empty field for the user phone number because we didn't have any mechanism to take contact from the user but now we are taking it and also displaying it.
Issue
#1215
Checklist