Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduced field of customer contact in service #1214

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Usmanfee
Copy link
Contributor

@Usmanfee Usmanfee commented Oct 10, 2024

Description

Introduced new input field for user contact in Register New Service and also made changes to display it in ServiceDetail and Valid and Publish at last step of Register New Service.

Changelog entry:

- **Customer Contact Field**:
  - Introduced new contact field in New Service Registration and Service Detail [#1214](https://github.com/eclipse-tractusx/portal-frontend/pull/1214)

Why

Previously, we were displaying the empty field for the user phone number because we didn't have any mechanism to take contact from the user but now we are taking it and also displaying it.

Issue

#1215

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have updated the changelog

@Usmanfee Usmanfee changed the title new: introduced new field of customer contact in service feat: Introduced new field of customer contact in service Oct 10, 2024
@Usmanfee Usmanfee force-pushed the new/user-contact-field-in-service branch from 89cb552 to 7152151 Compare October 21, 2024 13:07
@Usmanfee Usmanfee force-pushed the new/user-contact-field-in-service branch from bc55cee to 6afcde5 Compare October 24, 2024 12:51
@Usmanfee Usmanfee force-pushed the new/user-contact-field-in-service branch from 6afcde5 to f2d8b82 Compare October 24, 2024 21:42
@Usmanfee Usmanfee marked this pull request as ready for review October 24, 2024 21:43
@Usmanfee Usmanfee requested review from oyo and evegufy October 24, 2024 21:44
Copy link
Contributor

@ss-nikunj ss-nikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evegufy evegufy added this to the Release 25.03 milestone Nov 7, 2024
@evegufy evegufy changed the title feat: Introduced new field of customer contact in service feat: introduced new field of customer contact in service Nov 7, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check regex length condition once again

src/types/Patterns.ts Outdated Show resolved Hide resolved
@Usmanfee Usmanfee force-pushed the new/user-contact-field-in-service branch from 6c7561b to 13fe166 Compare November 12, 2024 13:02
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phone number check

src/types/Patterns.ts Show resolved Hide resolved
@Usmanfee Usmanfee force-pushed the new/user-contact-field-in-service branch from 71776a2 to 82811f9 Compare November 15, 2024 15:54
@Usmanfee Usmanfee changed the title feat: introduced new field of customer contact in service feat: introduced field of customer contact in service Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

7 participants