fix(offersubscription): skip optional autosetupprovidercallback if it is not configured #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntruchsess
force-pushed
the
bugfix/856-callbackurl
branch
9 times, most recently
from
f5e07f5 to
92cdc05
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/externalsystems/OfferProvider.Library/BusinessLogic/OfferProviderBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
… is not configured
ntruchsess
force-pushed
the
bugfix/856-callbackurl
branch
from
92cdc05 to
1860044
Compare
Phil91
approved these changes
Jul 24, 2024
|
evegufy
approved these changes
Jul 24, 2024
ntruchsess
added a commit
that referenced
this pull request
Jul 29, 2024
* fix(apps): remove leading '/' from the activate subscription endpoint (#861) Refs: #856 * bug(offersubscription): suppress activation of external serviceaccounts in keycloak on subscription-activation (#864) Refs: #856 * fix(dim): fix callback logic for dim requests (#863) Refs: #862 chore(dependencies): bump efcore to 8.0.7 (#857) * increase efcore version to latest 8.0.7 to resolve security-issue in transitive dependency in System.Text.Json * fix(offersubscription): skip optional autosetupprovidercallback if it is not configured (#865) * add clientPrefix to workers appsettings (#870) * fix: enhance subscription/provider endpoint with external Service data (#867) Refs: #841 * fix(sdDoc): set process step to skipped if ClearinghouseConnectDisabled is true (#874) Refs: #792 * build(deps): bump MimeKit from 4.3.0 to 4.7.1 (#833) eclipse-tractusx/portal#369 * build(deps): bump MimeKit from 4.3.0 to 4.7.1 in /tests/endtoend Bumps MimeKit from 4.3.0 to 4.7.1. --- updated-dependencies: - dependency-name: MimeKit dependency-type: direct:production ... * chore: upgrade mimekit in sendmail project * chore: update dependencies file --------- * upgrade implicit dependencies on System.Text.Json (#875) * Serilog.Settings.Configuration to 8.0.2 * remove redundant dependencies on Microsoft.Extensions.Hosting * bump framework version to 2.4.2 after merge of main --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Norbert Truchsess <[email protected]> Co-authored-by: Phil Schneider <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evelyn Gurschler <[email protected]> Reviewed-By: Evelyn Gurschler <[email protected]> Reviewed-By: Norbert Truchsess <[email protected]> Reviewed-By: Phil Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skip creation of TRIGGER_PROVIDER_CALLBACK processstep in case no callback-url is configured in ProviderCompanyDetails
skip execution of TRIGGER_PROVIDER_CALLBACK processstep in case no callback-url is configured in ProviderCompanyDetails
in processstep TRIGGER_PROVIDER_CALLBACK skip retrieval of service-account secret for external serviceaccounts
Why
in ProviderCompanyDetails the callbackurl is declared as optional (nullable). If it is not set the process-step TRIGGER_PROVIDER_CALLBACK is nevertheless created and executed but fails with error-message 'Callback Url should be set here'
Issue
#856
Checklist
Please delete options that are not relevant.