Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E Test 24.08] Callback from DIM Middle Layer | Validate for application status SUBMITTED #862

Closed
evegufy opened this issue Jul 23, 2024 · 1 comment
Closed

[E2E Test 24.08] Callback from DIM Middle Layer | Validate for application status SUBMITTED #862

evegufy opened this issue Jul 23, 2024 · 1 comment
Assignees
@Phil91 @evegufy
Labels
bug Something isn't working
Milestone
Release 2.1.0 (24...

Comments

@evegufy
Copy link
Contributor

evegufy commented Jul 23, 2024

Current Behavior

During E2E Testing we got into the situation that multiple companies with the same BPN were created: two company applications were cancelled (application status 9) and one company application (the relevant one) was in status SUBMITTED when the callback from the DIM Middle Layer was trigger with the wallet information. The callback did not add the information to the relevant company because the POST endpoint api/administration/registration/dim/{bpn} wasn't able to identify the relevant company:

[12:03:17 ERR] GeneralErrorHandler caught InvalidOperationException with errorId: 997d3396-a353-46a0-ae3d-eb9c537b534f resulting in response status code 500, message 'Sequence contains more than one element.'
System.InvalidOperationException: Sequence contains more than one element.

Expected Behavior

The endpoint POST endpoint api/administration/registration/dim/{bpn} takes the application status in consideration and is able to assign the information to the company.

Steps To Reproduce

Detected in version 2.1.0-RC2
@evegufy evegufy added the bug Something isn't working label Jul 23, 2024
@evegufy evegufy added this to Portal Jul 23, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 23, 2024
@evegufy evegufy moved this from NEW USER REQUEST to BACKLOG in Portal Jul 23, 2024
Phil91 added a commit that referenced this issue Jul 23, 2024
@Phil91
fix(dim): fix callback logic for dim requests
1c0534e 
Refs: #862
@Phil91 Phil91 mentioned this issue Jul 23, 2024
Merged
8 tasks
@evegufy evegufy added this to the Release 2.1.0 (24.08) milestone Jul 23, 2024
Phil91 added a commit that referenced this issue Jul 24, 2024
@Phil91 @ntruchsess
fix(dim): fix callback logic for dim requests (#863)
fd1bb04 
Refs: #862
Co-authored-by: Norbert Truchsess <[email protected]>
Reviewed-By: Evelyn Gurschler <[email protected]>
Reviewed-By: Norbert Truchsess <[email protected]>
@Phil91 Phil91 moved this from BACKLOG to IN REVIEW in Portal Jul 24, 2024
@evegufy
Copy link
Contributor Author

evegufy commented Jul 24, 2024

tested successfully

@evegufy evegufy closed this as completed Jul 24, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Jul 24, 2024
Phil91 added a commit that referenced this issue Jul 26, 2024
@Phil91 @ntruchsess
fix(dim): fix callback logic for dim requests (#863)
ee74902 
Refs: #862
Co-authored-by: Norbert Truchsess <[email protected]>
Reviewed-By: Evelyn Gurschler <[email protected]>
Reviewed-By: Norbert Truchsess <[email protected]>
ntruchsess added a commit that referenced this issue Jul 29, 2024
@Phil91 @ntruchsess
fix(dim): fix callback logic for dim requests (#863)
b441a46 
Refs: #862
Co-authored-by: Norbert Truchsess <[email protected]>
Reviewed-By: Evelyn Gurschler <[email protected]>
Reviewed-By: Norbert Truchsess <[email protected]>
ntruchsess added a commit that referenced this issue Jul 29, 2024
@ntruchsess
Merge pull request #884 from eclipse-tractusx/chore/merge_to_main
9dfa228 
* fix(apps): remove leading '/' from the activate subscription endpoint (#861)
Refs: #856
* bug(offersubscription): suppress activation of external serviceaccounts in keycloak on subscription-activation (#864)
Refs: #856
* fix(dim): fix callback logic for dim requests (#863)
Refs: #862
chore(dependencies): bump efcore to 8.0.7 (#857)
* increase efcore version to latest 8.0.7 to resolve security-issue in transitive dependency in System.Text.Json
* fix(offersubscription): skip optional autosetupprovidercallback  if it is not configured (#865)
* add clientPrefix  to workers appsettings (#870)
* fix: enhance subscription/provider endpoint with external Service data (#867)
Refs: #841
* fix(sdDoc): set process step to skipped if ClearinghouseConnectDisabled is true (#874)
Refs: #792
* build(deps): bump MimeKit from 4.3.0 to 4.7.1 (#833)
eclipse-tractusx/portal#369
* build(deps): bump MimeKit from 4.3.0 to 4.7.1 in /tests/endtoend
Bumps MimeKit from 4.3.0 to 4.7.1.
---
updated-dependencies:
- dependency-name: MimeKit
  dependency-type: direct:production
...
* chore: upgrade mimekit in sendmail project
* chore: update dependencies file
---------
* upgrade implicit dependencies on System.Text.Json (#875)
* Serilog.Settings.Configuration to 8.0.2
* remove redundant dependencies on Microsoft.Extensions.Hosting
* bump framework version to 2.4.2 after merge of main
---------
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Norbert Truchsess <[email protected]>
Co-authored-by: Phil Schneider <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evelyn Gurschler <[email protected]>
Reviewed-By: Evelyn Gurschler <[email protected]>
Reviewed-By: Norbert Truchsess <[email protected]>
Reviewed-By: Phil Schneider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phil91 Phil91

@evegufy evegufy

Labels
bug Something isn't working
Projects
Portal
Archived in project
Milestone
Release 2.1.0 (24.08)
Development

No branches or pull requests
2 participants
@Phil91 @evegufy