Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust documentation #198

Merged
merged 11 commits into from
Nov 20, 2023
Merged

chore: adjust documentation #198

merged 11 commits into from
Nov 20, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 16, 2023 •
edited by evegufy
Loading

Description

  • add docu for service account sync
  • add table of content to version upgrade
  • move iam specific docu to iam repo
  • add licence notice to md files in docs and developer directories
  • add license notice files for images (was missing for a few)
  • add check for license info in pr template
  • fix typos
  • implement linter findings

Why

To have the database changes documented and move the iam docu to the correct repo.
And to comply with trg-7-07/#documentation

Issue

N/A - Jira Issue: CPLP-3059 and CPLP-3229

Corresponding IAm PR

#31

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@Phil91 Phil91 requested review from evegufy and jjeroch and removed request for evegufy November 16, 2023 08:01
@Phil91 Phil91 marked this pull request as ready for review November 16, 2023 08:01
@Phil91 Phil91 mentioned this pull request Nov 16, 2023
Merged
3 tasks
@evegufy evegufy mentioned this pull request Nov 17, 2023
Closed
8 tasks
@Phil91 Phil91 force-pushed the feature/CPLP-3059-docu branch from e5c6ed8 to 304012e Compare November 20, 2023 08:06
@Phil91 Phil91 force-pushed the feature/CPLP-3059-docu branch from 304012e to 9097ae1 Compare November 20, 2023 08:06
@evegufy
Copy link
Contributor

evegufy commented Nov 20, 2023

@Phil91 I just created the following IP issue due to dependencies check failing:
A review is required for npm/npmjs/-/opener/1.5.2.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11619

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 merged commit 2ecad3f into eclipse-tractusx:release/v1.7.0-RC4 Nov 20, 2023
4 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3059-docu branch November 20, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@jjeroch jjeroch Awaiting requested review from jjeroch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy