Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move iam specific docu from assets to iam #31

Merged
merged 11 commits into from
Nov 27, 2023
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 16, 2023

Description

Move the documentation for iam from the assets repo to the iam repo

Why

To have the documentation at the correct place

Issue

N/A - Jira Issue: CPLP-3059

Corresponding Assets PR

#198

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my changes
  • I have successfully tested my changes

@Phil91 Phil91 requested review from evegufy and jjeroch November 16, 2023 08:02
@Phil91 Phil91 marked this pull request as ready for review November 16, 2023 08:02
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, would be great if you could provide the license files for the png files in the static dir and if you could also copy the script to auto create them https://github.com/eclipse-tractusx/portal-assets/blob/main/scripts/license.sh

and move those imgs also to the static dir and reference them accordingly

@Phil91 Phil91 requested a review from evegufy November 17, 2023 07:12
@Phil91 Phil91 force-pushed the feature/CPLP-3059-docu branch from b157035 to 008ea41 Compare November 20, 2023 12:18
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Phil91 Phil91 merged commit 56690ba into main Nov 27, 2023
4 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3059-docu branch November 27, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants