Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat|fix] : SDE frontend : Hotfix 3.2 with pcf - rel:2.3.0 #38

Closed

Conversation

sachinargade123
Copy link
Contributor

@sachinargade123 sachinargade123 commented Nov 21, 2023

Description

Fixed

  • Code optimisation for download file from server, Generic error handling, UI improvement .
  • trivy workflow updated.
  • version bump for chart release.
  • PCF documentation update

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor

@almadigabor Could you please help us create dependency review tickets for the below libraries?
npm/npmjs/@babel/code-frame/7.23.4
npm/npmjs/@babel/helper-string-parser/7.23.4
npm/npmjs/@babel/highlight/7.23.4

Thanks!

@carslen
Copy link
Contributor

carslen commented Nov 22, 2023

Done:

[main] INFO Querying Eclipse Foundation for license data for 500 items.
[main] INFO Found 145 items.
[main] INFO Querying Eclipse Foundation for license data for 500 items.
[main] INFO Found 94 items.
[main] INFO Querying Eclipse Foundation for license data for 290 items.
[main] INFO Found 51 items.
[main] INFO Querying ClearlyDefined for license data for 500 items.
[main] INFO Found 500 items.
[main] INFO Querying ClearlyDefined for license data for 500 items.
[main] INFO Found 500 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO
[main] INFO npm/npmjs/@babel/code-frame/7.23.4
[main] INFO npm/npmjs/@babel/helper-string-parser/7.23.4
[main] INFO npm/npmjs/@babel/highlight/7.23.4
[main] INFO
[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for npm/npmjs/@babel/highlight/7.23.4.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11658 .
[main] INFO A review is required for npm/npmjs/@babel/code-frame/7.23.4.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11659 .
[main] INFO A review is required for npm/npmjs/@babel/helper-string-parser/7.23.4.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11660 .

Tickets created:

DEPENDENCIES Outdated Show resolved Hide resolved
@ajithsimons
Copy link
Contributor

@carslen thanks for the quick support! Dependencies file has been updated. Please verify!

@MehranRoshandel
Copy link

@carslen, can you please help us to merge this PR by today?

- Legal information for distribution details added.
@adityagajbhiye9
Copy link
Contributor

Updated.
#41 Legal documents updated for docker image.

@adityagajbhiye9
Copy link
Contributor

adityagajbhiye9 commented Nov 23, 2023

fixed
#41 Updated Docker file for legal information.

@hzierer
Copy link

hzierer commented Nov 24, 2023

@carslen Dockerfile LGTM now

@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 27, 2023

Hi all,

in my opinion this is really hard to verfiy and IMHO i would reject this PR.

This looks for me to one PR to fix all problems... 👎🏼 not a good practice in my perspective.

Reason:

  • Hard to review
  • No transparency on what change fixed which issue without dedicated commit messages, etc.
  • Hard/impossible to create a proper changelog

The Best practices we nomally use 1 problem like docs / 1 pr / dedicated commit messages why to change and what to improve.

if i read the description correctly that would be at least 6 PR´s like:

  1. Code optimisation for download file from server
  2. Generic error handling
  3. UI improvement
  4. trivy workflow updated
  5. version bump for chart release
  6. PCF documentation update

Only guessing is it possible for you @sachinargade123 to split all your changes in separate PR´s or generating new ones? This is also the reason why we as a system team generate multible issues for each TRG section.

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is too big as followed our guidelines.
https://www.eclipse.org/projects/handbook/#ip-project-content

@sachinargade123
Copy link
Contributor Author

We are closing this PR. We will create new PR's.

@ajithsimons ajithsimons deleted the hotfix_3.2_with_pcf branch February 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants