-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat|fix] : SDE frontend : Hotfix 3.2 with pcf - rel:2.3.0 #38
[feat|fix] : SDE frontend : Hotfix 3.2 with pcf - rel:2.3.0 #38
Conversation
Fe documentation
### Fixed - permissions updated. - trivy workflow updated. - bug fixes. - version bump for chart release.
@almadigabor Could you please help us create dependency review tickets for the below libraries? Thanks! |
Done:
Tickets created: |
@carslen thanks for the quick support! Dependencies file has been updated. Please verify! |
@carslen, can you please help us to merge this PR by today? |
- Legal information for distribution details added.
Updated. |
fixed |
@carslen Dockerfile LGTM now |
Hi all, in my opinion this is really hard to verfiy and IMHO i would reject this PR. This looks for me to one PR to fix all problems... 👎🏼 not a good practice in my perspective. Reason:
The Best practices we nomally use 1 problem like docs / 1 pr / dedicated commit messages why to change and what to improve. if i read the description correctly that would be at least 6 PR´s like:
Only guessing is it possible for you @sachinargade123 to split all your changes in separate PR´s or generating new ones? This is also the reason why we as a system team generate multible issues for each TRG section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is too big as followed our guidelines.
https://www.eclipse.org/projects/handbook/#ip-project-content
We are closing this PR. We will create new PR's. |
Description
Fixed
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: