Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRG 7.05] Missing legal decuments in Docker image #41

Closed
hzierer opened this issue Nov 23, 2023 · 5 comments
Closed

[TRG 7.05] Missing legal decuments in Docker image #41

hzierer opened this issue Nov 23, 2023 · 5 comments

Comments

@hzierer
Copy link

hzierer commented Nov 23, 2023

Hi @adityagajbhiye9,

the frontend docker image is missing the legal information for distribution. Can you please update your Dockerfile accordingly.

@adityagajbhiye9
Copy link
Contributor

@hzierer We have included in README.MD(https://github.com/eclipse-tractusx/managed-simple-data-exchanger-frontend/blob/main/README.md)
Please let us know any concern.

@adityagajbhiye9
Copy link
Contributor

adityagajbhiye9 commented Nov 23, 2023

Added legal documents for docker image.
@hzierer Please review.

@hzierer
Copy link
Author

hzierer commented Nov 23, 2023

yes, it is good to have this new docker notice file, but as I linked in my fist post above: These 3-4 files have to be in the actual docker image.
Please copy LICENCE, NOTICE.md, DEPENDECIES and SECURITY.md into the WORKDIR (/usr/share/nginx/html) of your container.

Reason is that the image will be uploaded to dockerhub and these files have to be there too. It's a legal requirement.

@adityagajbhiye9
Copy link
Contributor

@hzierer Added copy cmd for legal files in dockerfile.

@hzierer
Copy link
Author

hzierer commented Nov 28, 2023

Done. Issue fixed with 84b8185

@hzierer hzierer closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants