[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0 #68

sachinargade123 · 2023-11-21T11:25:35Z

Description

Added

Added oauth security for sde public api.
BPN url add API path.

Fixed

DT use refactor and PCF issue fix.
Correct dataplane endpoint for digital twin.
DSP endpoint path for digital-twin edc url.
trivy worklow fix.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files

### Added - Added oauth security for sde public api. - BPN url add API path. ### Fixed - DT use refactor and PCF issue fix. - Correct dataplane endpoint for digital twin. - DSP endpoint path for digital-twin edc url. - trivy worklow fix.

- image update and trivy vulernablities fixes.

almadigabor

Can you please address my question below?

almadigabor · 2023-11-21T14:00:55Z

INSTALL.md

- JDK18
- Postgres 11.9.13
+- JDK17
+- Postgres 13.2.11


Why do you specify Postgres v13 when in your helm chart you use chart version 11.x.x which potentially means Postgres v15?

Sorry, I was wrong, Bitnami's Postgresql chart version 11.x.x means Postgresql v14. Although based on this TRG you should have already moved/upgraded to Postgres v15 which is chart version 12.x.x.

We will be using Postgres v16. Can we use Postgres v13.X.X.

Postgress upgraded to v15.

adityagajbhiye9 · 2023-11-22T06:42:53Z

@almadigabor Changes made as per suggested.
#69 is fixed. Changed in run cmd.

adityagajbhiye9 · 2023-11-23T04:53:20Z

Fixed
#71 Notice.md updated.

ChetanT-System · 2023-11-23T06:38:11Z

Fixed
#70
Please review @sachinargade123

MehranRoshandel · 2023-11-23T09:26:42Z

@almadigabor, can you please help us to merge this PR by today?

hzierer · 2023-11-24T09:58:27Z

can you please update the dependencies file? I also open a PR for that 3 days ago.

sachinargade123 · 2023-11-24T10:23:19Z

@hzierer,

We have already Updated Dependencies file.

Thanks for created PR, We have checked it but that is not sufficient, our SDE backend is multi maven model project so it should scan all project and autogenerate dependency file. We will take look and generate DEPEDENCY file automatically.

adityagajbhiye9 · 2023-11-24T12:34:00Z

@almadigabor Can we merge the PR?

hzierer · 2023-11-24T14:12:24Z

I split the old PR in two separate ones and fixed the dash tool to include the testing scope:
#72
#73

MehranRoshandel · 2023-11-24T14:42:15Z

So it is reviewed and can be merged now. Correct?

sachinargade123 · 2023-11-24T15:07:59Z

@hzierer
We had already included this #73 changes in here sde-core maven model where actual application jar get build . May be we don't require this changes.

hzierer · 2023-11-24T15:32:52Z

@hzierer We had already included this #73 changes in here sde-core maven model where actual application jar get build . May be we don't require this changes.

yeah ok, it might be obsolete then. just saw that you are creating two jars and wanted to make sure that theese documents are part of all. But I assume then, that only the one in sde-core is distributed to dockerhub

FaGru3n

This PR is too big as followed our guidelines
https://www.eclipse.org/projects/handbook/#ip-project-content

sachinargade123 · 2023-11-27T16:19:17Z

Ok sure we are closing this PR and we will open new PRs.

sachinargade123 and others added 18 commits October 17, 2023 13:05

DT use refactor and PCF issue fix

891ca3c

Log twin look up status

c4f16b7

Create sdebuild

e657b77

Added DSP enpoint path for digitaltwin edc url

95ad0bc

Update pcf schema for companyId

a717747

Rename sdebuild to sdebuild.yml

4fc06ce

BPN url add API path

1a0f35a

Hide PCF submodel from loading

3f838fb

Correct dataplane endpoint for digital twin

addcb72

remove submodel path from twin

82a56d7

Added oauth security for sde pulic api

5d87143

Update sdebuild.yml

678361f

[SDE_backend] rel-2.3.1 and Change log update

1bff180

### Added - Added oauth security for sde public api. - BPN url add API path. ### Fixed - DT use refactor and PCF issue fix. - Correct dataplane endpoint for digital twin. - DSP endpoint path for digital-twin edc url. - trivy worklow fix.

Update CHANGELOG.md

ed88ffe

Updated Readme

bc3db95

Use jdk 17 for trivy issues

3bfb7e8

Docker image update

5ecd4e8

- image update and trivy vulernablities fixes.

revert pcf sumodel changes

c878234

sachinargade123 requested a review from almadigabor November 21, 2023 11:27

almadigabor reviewed Nov 21, 2023

View reviewed changes

adityagajbhiye9 added 2 commits November 22, 2023 10:40

User-id Changes for docker file.

16f044e

updated postgres chart version

5acca92

adityagajbhiye9 added 2 commits November 22, 2023 13:56

Removed r

2b63170

updated notice.md

090ff08

Fixes #70

a75d572

MehranRoshandel mentioned this pull request Nov 23, 2023

Simple Data Exchanger (SDE) Release 23.12 Documentation Acceptance Criteria eclipse-tractusx/sig-release#78

Closed

6 tasks

FaGru3n suggested changes Nov 27, 2023

View reviewed changes

sachinargade123 closed this Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0 #68

[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0 #68

sachinargade123 commented Nov 21, 2023 •

edited

Loading

almadigabor left a comment

almadigabor Nov 21, 2023

almadigabor Nov 21, 2023 •

edited

Loading

adityagajbhiye9 Nov 22, 2023 •

edited

Loading

adityagajbhiye9 Nov 22, 2023

adityagajbhiye9 commented Nov 22, 2023 •

edited

Loading

adityagajbhiye9 commented Nov 23, 2023

ChetanT-System commented Nov 23, 2023

MehranRoshandel commented Nov 23, 2023

hzierer commented Nov 24, 2023 •

edited

Loading

sachinargade123 commented Nov 24, 2023 •

edited

Loading

adityagajbhiye9 commented Nov 24, 2023

hzierer commented Nov 24, 2023

MehranRoshandel commented Nov 24, 2023

sachinargade123 commented Nov 24, 2023

hzierer commented Nov 24, 2023 •

edited

Loading

FaGru3n left a comment

sachinargade123 commented Nov 27, 2023

[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0 #68

[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0 #68

Conversation

sachinargade123 commented Nov 21, 2023 • edited Loading

Description

Added

Fixed

Pre-review checks

almadigabor left a comment

Choose a reason for hiding this comment

almadigabor Nov 21, 2023

Choose a reason for hiding this comment

almadigabor Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

adityagajbhiye9 Nov 22, 2023 • edited Loading

Choose a reason for hiding this comment

adityagajbhiye9 Nov 22, 2023

Choose a reason for hiding this comment

adityagajbhiye9 commented Nov 22, 2023 • edited Loading

adityagajbhiye9 commented Nov 23, 2023

ChetanT-System commented Nov 23, 2023

MehranRoshandel commented Nov 23, 2023

hzierer commented Nov 24, 2023 • edited Loading

sachinargade123 commented Nov 24, 2023 • edited Loading

adityagajbhiye9 commented Nov 24, 2023

hzierer commented Nov 24, 2023

MehranRoshandel commented Nov 24, 2023

sachinargade123 commented Nov 24, 2023

hzierer commented Nov 24, 2023 • edited Loading

FaGru3n left a comment

Choose a reason for hiding this comment

sachinargade123 commented Nov 27, 2023

sachinargade123 commented Nov 21, 2023 •

edited

Loading

almadigabor Nov 21, 2023 •

edited

Loading

adityagajbhiye9 Nov 22, 2023 •

edited

Loading

adityagajbhiye9 commented Nov 22, 2023 •

edited

Loading

hzierer commented Nov 24, 2023 •

edited

Loading

sachinargade123 commented Nov 24, 2023 •

edited

Loading

hzierer commented Nov 24, 2023 •

edited

Loading