Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRS-739_add_value_for_submodel_url_for_IRS_version_4.5.2 #747

Conversation

poojapatel23
Copy link

@poojapatel23 poojapatel23 commented Jul 2, 2024

fix(edc-client): Add property "submodel-postfix" to be prefixed for submodel call for IRS version 4.5.2

Description

Task : #739

Added $Value to submodel URL for IRS version 4.5.2 and updated submodel URL to hotfix tracex

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

fix(edc-client): Add property "submodel-postfix" to be prefixed for submodel call for IRS version 4.5.2
@poojapatel23 poojapatel23 reopened this Jul 2, 2024
@poojapatel23 poojapatel23 reopened this Jul 2, 2024
@poojapatel23 poojapatel23 changed the base branch from main to hotfix/release-4.5.3 July 2, 2024 11:24
@poojapatel23 poojapatel23 requested a review from ds-jhartmann July 2, 2024 11:24
@ds-jhartmann
Copy link
Contributor

@poojapatel23 The GitHub workflows were not executed on this PR. Without them, I cannot merge the PR.
Can you check, if you have GitHub actions enabled on your fork?
It this does not help, try to rebase your branch onto eclipse-tractusx:hotfix/release-4.5.3

@poojapatel23 poojapatel23 reopened this Jul 4, 2024
@poojapatel23 poojapatel23 reopened this Jul 5, 2024
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit 500e366 into eclipse-tractusx:hotfix/release-4.5.3 Jul 5, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants