Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/$value" for submodel URL is missing for 24.03 version of IRS #739

Closed
rogocof opened this issue Jun 27, 2024 · 4 comments
Closed

"/$value" for submodel URL is missing for 24.03 version of IRS #739

rogocof opened this issue Jun 27, 2024 · 4 comments
Assignees

Comments

@rogocof
Copy link

rogocof commented Jun 27, 2024

Description

Fetching of submodels is not working because the URL is built wrongly.
We need to backport/cherry pick a bugfix for 24.03 (4.5.2) cfc065c

Current behaviour

The issue is that the IRS does not append the “/$value” suffix to the URL like it is described in the standard

Expected behavior

Append the “/$value” suffix to the URL like in the Bugfix cfc065c

image

Steps to reproduce the Bug

Let IRS fetch any submodel and you will see that it tries to reach the URL without the suffix.

@rogocof
Copy link
Author

rogocof commented Jun 27, 2024

@mkanal
Please prioritize this bug.

@poojapatel23 will work on the fix during my absence in the next days

Questions to @ds-jhartmann:

  1. Against which branch should we create the PR?
  2. Is there a specific process to create the tag after the merge? Are we allowed/permitted to do that?

@ds-jhartmann
Copy link
Contributor

@rogocof the branch should be created off of this tag https://github.com/eclipse-tractusx/item-relationship-service/tree/4.5.2

The release process is described here, but you require eclipse-committer status to create tags and merge PRs.
I can do that once the changes are prepared

@rogocof
Copy link
Author

rogocof commented Jun 27, 2024

Thanks @ds-jhartmann
@poojapatel23 do you need more information to prepare the fix?

@mkanal mkanal moved this from inbox to backlog in IRS Jul 9, 2024
@mkanal mkanal moved this from backlog to done in IRS Jul 23, 2024
@mkanal mkanal closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

3 participants