Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Authentication in IRS #259

Closed
6 tasks done
jzbmw opened this issue Nov 7, 2023 · 5 comments
Closed
6 tasks done

Refactor Authentication in IRS #259

jzbmw opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation linked_to_feature Issue is linked to a feature

Comments

@jzbmw
Copy link
Contributor

jzbmw commented Nov 7, 2023

As PO,
I want to change the authentication of the IRS,
so that it is more efficient to integrate the service.

Hints / Details

Outcome / Acceptance Criteria

Outcome

Acceptance Criteria

  • Auth process has been changed to API_Keys (Different API Keys for different roles)
  • IRS has APIKeys enabled per default
  • IRS OAuth2 Authentication is not able to be used via configuration
  • IRS OAuth2 linked to a tag where OAuth2 is integrated into the documentation.
  • Documentation is updated accordingly
  • two roles, two token

Out of Scope

  • ...
@jzbmw jzbmw added this to IRS Nov 7, 2023
@jzbmw jzbmw moved this to inbox in IRS Nov 7, 2023
@jzbmw jzbmw added dependencies Pull requests that update a dependency file bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 7, 2023
@jzbmw jzbmw changed the title Clarify irs_admin CPLP-3254 with Julia Refactor Authentication in IRS Nov 8, 2023
@mkanal mkanal moved this from inbox to backlog in IRS Nov 14, 2023
@jzbmw jzbmw added the BLOCKED Items which are blocked by dependencies label Nov 24, 2023
@jzbmw
Copy link
Contributor Author

jzbmw commented Nov 24, 2023

Blocked by Meeting, of which we need input on how to change this.

@jzbmw jzbmw moved this from backlog to next in IRS Nov 28, 2023
@jzbmw jzbmw moved this from next to backlog in IRS Nov 28, 2023
@jzbmw jzbmw removed the BLOCKED Items which are blocked by dependencies label Dec 6, 2023
@mkanal mkanal added the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Dec 11, 2023
@jzbmw jzbmw removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Dec 12, 2023
@jzbmw
Copy link
Contributor Author

jzbmw commented Dec 12, 2023

As described in the Acceptance Criteria

@jzbmw jzbmw moved this from backlog to next in IRS Dec 12, 2023
@ds-jhartmann
Copy link
Contributor

Planning 2

  • Remove OAuth authentication from the IRS Controllers (IRS, ESS, Policy Store) and configuration regarding this
  • IRS authentication uses API Keys. 1 Key with view_irs access, 1 Key with admin_irs access
  • Keys can be configured via application and helm configuration (stored in vault for DEV and INT environments)
  • Remove OAuth based documentation and replace with documentation about new API Keys
  • Add link of current tag to documentation for a reference implementation of OAuth2 (link to eclipse-tractusx repo)
  • Update Insomnia collection to API Key based authentication
  • Update Cucumber and Tavern test authentication to API Key
  • Update ESS Demo script authentication

@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Dec 12, 2023
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Dec 12, 2023
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
…api-key

feat(impl):[#259] new authentication through api key impl
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
feat(impl):[#259] update insomnia collection to use apiKeys
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to review in IRS Jan 15, 2024
@ds-alexander-bulgakov
Copy link
Contributor

ds-alexander-bulgakov commented Jan 16, 2024

Update after several tryouts and retests: Change to API-Keys is working fine on IRS after the correct secrets were set in #397, all requests can be sent out and either tavern- and cucumber-tests can be run as expected.
Currently ESS-INT has authentication issues, this is investigated by @ds-ext-kmassalski. Test ongoing.

Update: After the helm-version on ESS-INT (PR #720) and authentication for tavern-tests (PR #721) has been adjusted also the ESS-INT tests should run successfully. Test ongoing.

ds-jhartmann pushed a commit that referenced this issue Jan 16, 2024
…date

feat(impl):[#259] update tavern and cucumber workflows
ds-jhartmann pushed a commit that referenced this issue Jan 16, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 16, 2024
…avern-tests

feat(impl):[#259] update ess-int tavern test authentication
@ds-alexander-bulgakov
Copy link
Contributor

ds-alexander-bulgakov commented Jan 17, 2024

Update: After the INT_ADMIN_USER secrets were updated with correct values in #397 all tests could be run as without authentication errors.
Documentation has been updated. Ticket is ready for PO-review, FYI @jzbmw.

@jzbmw jzbmw moved this from review to done in IRS Jan 22, 2024
@jzbmw jzbmw closed this as completed Jan 22, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

5 participants