feature: eclipse-tractusx/traceability-foss#639 add catch clause #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmf
suggested changes
Jul 9, 2024
| @@ -39,4 +42,12 @@ public EdcClientException(final Throwable cause) { | |||
| public EdcClientException(final String msg) { | |||
| super(msg); | |||
| } | |||
|
|
|||
| public String getBusinessPartnerNumber() { | |||
There was a problem hiding this comment.
this violates the Liskov Substitution Principle (LSP):
The base exception class EdcClientException throws NotImplementedException for the methods getBusinessPartnerNumber() and getPolicy(). If subclasses override these methods to provide actual implementations, then the behavior of instances of the subclass when accessed via a reference of the superclass will differ from those of the superclass.
This can lead to unexpected behavior at runtime if the code handling exceptions assumes that these methods are always implemented (since they're part of the class's interface), leading to potential runtime errors or crashes.
Maybe there is a better solution using a common interface?
…interface for policy exceptions
ds-lcapellino
force-pushed
the
feature/639-handle-policy-expiration
branch
from
ebea478 to
3a53557
Compare
dsmf
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: