Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Security TRG 8 UPDATED #681
doc: Security TRG 8 UPDATED #681
Changes from 14 commits
2f130c7
5eb555c
84c2195
1c09c63
47b4add
34e362d
513590a
68b4111
2ed2681
0eb1838
39aacf3
35c06c7
a073b04
8bfa754
07e1014
3e779d4
58905f7
6540bbc
076e242
7778f1f
06f3f7c
7a1c81a
369cd06
aa22049
92a0108
a10ccb5
97c0118
51c3d81
c332531
6c75967
b44cd12
1ae0a02
358fc04
3a42ef3
7d1b949
59b8517
c64d434
491cb5c
8b8a49f
d613ace
1f66c56
c708ac0
5ae780b
f36ad75
20f5a70
1589198
d36836a
f88c5c8
5217ab7
2e425e3
d835bc3
23afbc7
cbf234b
7dba489
c4078ca
ee7280a
25b350b
d7dbefb
f951d20
f9bf291
174bce0
8d48374
2c79c51
d29c3d7
a297b38
10f5ca4
291e35d
393dc15
75c15ea
3923610
fae42e0
5d1702b
b7043c9
9f96b14
ddbe6cd
1e0c6cf
8a149d3
8caf99c
82a23a2
810521c
16e7b83
c0d4b99
d5bfa3b
02b3c89
4a8ab8a
52e39dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best practices cover the security workflows which are detailed in the next sections, correct? Like, in general not all CICD workflows need run on a schedule of course.
Maybe make the scope of these best practices, i.e. the workflows for the given security scans more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoprow Yes, it is in the next sections. You can find there descriptions with workflows for each tool that we are currently using.
"Maybe make the scope of these best practices, i.e. the workflows for the given security scans more explicit." - like I wrote before, you can find it in TRG 8.01-TRG 8.05.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the other tools? What is the best practice here? Rather enabling them or rather not on each pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"5.Pull Requests (PRs): It's not mandatory for workflows to run with every PR. Nonetheless, the Secret Scan is strongly recommended and deemed sufficient." means that it's not mandatory for workflows to run with every PR, except Secret Scanning.
"Following, here are specific guidelines and best practices for developers:" which means that all of those steps are best practice. In step 5 best practice is related to Secret Scan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best practice says its not mandatory to run a security workflow on every pull request but here it is the default. Should the best practice then not say it is recommended to run every workflow on each pull request? Or should this here be removed on default to fit more with the best practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicoprow Trivy, KICS and CodeQL are different types of scanners, that's the reason why workflows might be different. I made changes, please review them and let me know if now it's more clear for you. Thank you in advance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is an interesting one. Here we trying to decide whether its worth it to run the analysis at all on a push. In theory you could make more use of that in other workflows as well. CodeQL for example does not need to be run on changes to Helm charts or docs. Is that something that should be recommended to do in the best practices?
Or another take: Since the workflow will be executed on schedule anyway regardless of any change is defining exclusions like this unnecessary in the first place?