-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Security TRG 8 UPDATED #681
Conversation
This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics.
Security TRG
This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I added some comments.
Removing Dependabot section because there is PR regarding it and Tomasz Barwicki is working on this
After discussion about Owasp ZAP on security meeting, we decided that for now we won't add Owasp ZAP to TRG
Thank you for all your feedback. I updated TRGs. |
Hi @klaudiaZF , I would love to make a few changes, can I make them directly in your code? |
Hi @scherersebastian yes, of course |
Releasing TRG 8 as draft
We aligned all changes and through careful consideration of all feedback and collaborative refinements, we're releasing Security TRG 8 as a draft to solicit further suggestions for improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If TRG 00 is gone now, please add the information about expected quality to the individual TRGs and add this note to the Trivy TRG.
Caution about passing QG
@evegufy Thank you for your feedback. I've made the changes as we discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Let's release it to draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. I recommend to squash merge the PR.
As 86 (for the most part redundant) commits for one PR, I'd consider spamming the git history.
requested changes where implemented
Description
This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: