Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Security TRG 8 UPDATED #681

Merged
merged 86 commits into from
Mar 8, 2024
Merged

doc: Security TRG 8 UPDATED #681

merged 86 commits into from
Mar 8, 2024

Conversation

klaudiaZF
Copy link
Contributor

Description

This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics.
This PR brings enhancement to the existing TRG with a new addition of TRG 8.0 for Security specific topics
@klaudiaZF klaudiaZF changed the title doc: Security TRG 8 doc: Security TRG 8 UPDATED Feb 16, 2024
@klaudiaZF klaudiaZF requested a review from RolaH1t February 16, 2024 13:17
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I added some comments.

docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-01.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-06.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-07.md Outdated Show resolved Hide resolved
Removing Dependabot section because there is PR regarding it and Tomasz Barwicki is working on this
After discussion about Owasp ZAP on security meeting, we decided that for now we won't add Owasp ZAP to TRG
@klaudiaZF
Copy link
Contributor Author

Thank you for all your feedback. I updated TRGs.

@scherersebastian
Copy link
Member

Hi @klaudiaZF , I would love to make a few changes, can I make them directly in your code?

@klaudiaZF
Copy link
Contributor Author

Hi @scherersebastian yes, of course

docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
@klaudiaZF
Copy link
Contributor Author

We aligned all changes and through careful consideration of all feedback and collaborative refinements, we're releasing Security TRG 8 as a draft to solicit further suggestions for improvement.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If TRG 00 is gone now, please add the information about expected quality to the individual TRGs and add this note to the Trivy TRG.

@scherersebastian
Copy link
Member

If TRG 00 is gone now, please add the information about expected quality to the individual TRGs and add this note to the Trivy TRG.

@evegufy Thank you for your feedback. I've made the changes as we discussed.

Copy link
Member

@scherersebastian scherersebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Let's release it to draft.

docs/release/trg-8/trg-8-02.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-00.md Outdated Show resolved Hide resolved
docs/release/trg-8/trg-8-01.md Outdated Show resolved Hide resolved
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I recommend to squash merge the PR.
As 86 (for the most part redundant) commits for one PR, I'd consider spamming the git history.

@scherersebastian scherersebastian dismissed tomaszbarwicki’s stale review March 8, 2024 11:22

requested changes where implemented

@scherersebastian scherersebastian merged commit 4734a78 into eclipse-tractusx:main Mar 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants