Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(single-api): single api functionality #308

Merged
merged 38 commits into from
May 10, 2024

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented May 6, 2024

Caution

FIRST MERGE PARENT PR: #306 !

Why we create this PR?

To create a Single API Post method that allows to retrieve the passports data by abstracting of all the API's calls needed to do so, by authenticate with an API Key and fill the requested data in the body.

What we want to achieve with this PR?

We want to be able to retrieve the passport with only one API call.

What is new?

Added

  • SingleApiRequest class for the requested data for the single API.
  • SingleApiConfig class to had configurations related to the single API.

Updated

  • Updated ApiController with the singleApi POST method.
  • Updated ContractController by creating call methods (create, search, agree and status) without the authentication step to call in the Single API.
  • Updated AuthenticationService by adding the isSingleApiAuthenticated method to authenticate the single API key.
  • Updated application.yaml with the single api configurations.
  • Updated deployment-backend.yaml with the oauth.apiKey.
  • Updated values-int/beta/dev.yaml files with the oauth.apiKey.
  • Updated spring boot to version v3.2.5 from v3.2.4

PR Linked to:

Closes #277

dsrparracho and others added 28 commits March 7, 2024 16:04
with ned
eeded classes to
work
@matbmoser matbmoser added enhancement New feature or request backend Issue or PR connected to the backend application labels May 6, 2024
@matbmoser
Copy link
Contributor Author

@matbmoser
Copy link
Contributor Author

there was some merge issues in the parent


Long validUntil = dtr.getValidUntil();
//Check if invalid time has come
if (dtr.getInvalid() && validUntil > currentTimestamp) {

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
validUntil
may be null at this access as suggested by
this
null guard.
@matbmoser
Copy link
Contributor Author

matbmoser commented May 7, 2024

For the spring boot I have updated to the latest version to solve the security problems.

  • Executed IP checks

@matbmoser matbmoser merged commit 04a7f94 into eclipse-tractusx:main May 10, 2024
7 checks passed
@matbmoser matbmoser deleted the release/v3.0.0-single-api branch May 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue or PR connected to the backend application enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Merge and verify single api functionality
3 participants