Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(single-api): retrieve passport data from single API call in the dpp-backend #296

Closed
wants to merge 53 commits into from
Closed

feat(single-api): retrieve passport data from single API call in the dpp-backend #296

wants to merge 53 commits into from

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

To create a single API POST method that allows to retrieve the passports data by abstracting of all the API calls needed to do so. Authentication is done using the API Key method.

What we want to achieve with this PR?

The passport data should be retrieved with only one backend API call.

What is new?

Added

  • Added SingleApiRequest class for the requested data for the single API.
  • Added SingleApiConfig class to had configurations related to the single API.
  • Added SingleApi configuration to the main and backend helm charts in charts/digital-product-pass and dpp-backend/charts/digital-product-pass-backend
  • Added relevant documentaton

Updated

  • Updated ApiController with the singleApi POST method.
  • Updated ContractController by creating call methods (create, search, agree and status) without the authentication step to call in the Single API.
  • Updated AuthenticationService by adding the isSingleApiAuthenticated method to authenticate the single API key.
  • Updated application.yaml with the single api configurations.

Issue(s) Linked to:

#277

dsrparracho and others added 30 commits March 7, 2024 16:04
@dsrparracho
feat: developed the simple api controller
7f2770c 
with ned
eeded classes to
work
@dsrparracho
feature: fixed single-api configuration name in application.yaml and …
a901880 
…SimpleApiConfig class
@dsrparracho
Merge branch 'main' of https://github.com/catenax-ng/tx-digital-produ…
495771b 
…ct-pass into feature/cmp-1025/single-api
@dsrparracho
feat: updated the changelog.md and fixed the name of SingleApiConfig …
caee9fc 
…class
@matbmoser
chore: added latest chart changes from edc integration branch
aab4859
@dsrparracho
feat: fixed oauth.apiKey secret name on authentiacion service call an…
c612a44 
…d added error handling
@dsrparracho
Merge branch 'feature/cmp-1025/single-api' of https://github.com/cate…
22a6e26 
…nax-ng/tx-digital-product-pass into feature/cmp-1025/single-api
@matbmoser
fix: fixed structure from default values configuration2
0e2dc9f
@matbmoser
fix: fixed structure from default values configuration
3401bd4
@matbmoser
chore: added info messages to describe progress
d05b199
@matbmoser
fix: fixed methods parameters removing response
acc03f8
@matbmoser
feat: created first abstractino of contract controller into contract …
5bfa8c7 
…service
@dsrparracho
feat: concluded the ContractService class and updated API and Contrac…
17a3213 
…t controllers
@matbmoser
feat: added delay in simple api configuration
2f14dc5
@dsrparracho
chore: removed debug logs and added information in docs related to si…
e72e9d3 
…ngle api
@dsrparracho
chore: switch info from single api from DataRetrievalGuide to Arc42 doc
2fc6424
@saudkhan116
feature: added policy check configuration to the backend
ebc2b18
@saudkhan116
Merge branch 'develop' of https://github.com/catenax-ng/tx-digital-pr…
8a83945 
…oduct-pass into feature/cmp-1147/dtr-policy-check
@saudkhan116
chore: added policy constraints to backend configuration - work in pr…
b2885d9 
…ogress
@matbmoser
feat: feature and tests for parsing policy contraints
e3fee29
@matbmoser
feat: restructured policy/negotiation models directory and implemente…
8cdb11f 
…d initial policy parsing logic
@matbmoser
feat(policy): added action configuration for policies
4ad78bf
@matbmoser
feat: fixed details in the EdcUtil and Test components
3bb57e4
@matbmoser
feat: implemented logic to compare incomming and configured policies …
4d87498 
…with hashes
@saudkhan116
chore(fix): fixed typos in LICENSE, SECURITY readme and in springboot…
f439931 
… application.yaml
@saudkhan116
chore(refactor): add apiKey check in AuthenticationService
5429091
@saudkhan116
Merge branch 'develop' into feature/cmp-1025/single-api
d943a99
@saudkhan116
chore(refactor): renamed helm secret-template and their references, r…
5de5189 
…emove values dev and beta files
@saudkhan116
chore(refactor): refactored standalone backend helm chart, updated ch…
a658d4a 
…art versions to v2.3.0
@matbmoser
feat: implemented default policy check and defined strict mode
fd43130
@matbmoser
Copy link
Contributor

We need to test this before I can approve to merge

matbmoser and others added 14 commits April 29, 2024 17:19
@matbmoser
feat(data-sovereignty): created contract filter function by policies
4c33ad3
@matbmoser
feat(policy-selection): united selection of policy and contract in 's…
71f7a55 
…election objectÂÂÂ'
@matbmoser
fix: adjusted copyright headers
45ac9b1
@matbmoser
Merge pull request eclipse-tractusx#304 from eclipse-tractusx/hotfix/…
3fbaa62 
…fixed-license-headers

fix: adjusted copyright headers
@matbmoser
Merge branch 'eclipse-tractusx:main' into develop
ae1d607
@matbmoser
chore(bin): removed compiled bin files and folder
30af01d
@matbmoser
Merge branch 'eclipse-tractusx:main' into develop
4ea36ac
@matbmoser
chore: updated contract controller.java
e6a4934
@matbmoser
merge(main): merged main changes to dtr-policy-check
a9c0b43
@matbmoser
chore(license): updated license headers
bd2122f
@matbmoser
Merge pull request #250 from catenax-ng/feature/cmp-1147/dtr-policy-c…
7481bbb 
…heck

Feature/cmp 1147/dtr policy check: Enable policy configuration in the digital product pass backend component for dDTR
@matbmoser
merge(develop): updated branch with latest develop changes
f38a59c
@matbmoser
merge(develop): updated branch with latest develop changes
ccbc8a2
@matbmoser
fix(merge): fixed unupdated functionalities
56ef97a
@matbmoser matbmoser force-pushed the feature/cmp-1025/single-api branch from 105eb85 to 56ef97a Compare May 6, 2024 12:56
matbmoser
matbmoser requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@matbmoser matbmoser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no sense in this PR since we already have one with the latest updates integrated #308

@matbmoser matbmoser closed this May 10, 2024
@saudkhan116 saudkhan116 deleted the feature/cmp-1025/single-api branch June 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbmoser matbmoser matbmoser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saudkhan116 @matbmoser @dsrparracho